options_field_views_data() excludes fields with an allowed_values_function for no reason

+++ b/core/modules/options/options.views.inc
@@ -17,12 +17,6 @@
 
-  $function = $field->getSetting('allowed_values_function');
-  // If this field makes use of dynamic allowed options, we ignore the views
-  // setting.
-  if (!empty($function)) {
-    return $data;
-  }

yeah so now we support dynamic values ... and we just have to hope that they are written in a entity agnostic way,
I guess we don't have any kind of metadata about it.

I'll take a stab at a test.

Here's a test. I extended the OptionsTestBase since that is a unit test rather than a full-blown web test.

That makes sense--how's this?

Now that #2443485: Remove extension:views cache tag and other views related cache improvements is in, here's the test w/o the manual cache clear.

Yeah it's good to go.

I wouldn't mind @dawehner input either :)

+++ b/core/modules/options/options.views.inc
@@ -19,12 +19,6 @@
-  $function = $field->getSetting('allowed_values_function');
-  // If this field makes use of dynamic allowed options, we ignore the views
-  // setting.
-  if (!empty($function)) {
-    return $data;
-  }

Now that you can call options_allowed_values() this is pretty save.

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 5538c44 and pushed to 8.0.x. Thanks!