MenuLinkContent::baseFieldDefinitions() has a couple $field->setSetting('default_value', $foo).
That doesn't work, 'default_value' is not a field setting, this should use setDefaultValue() instead.

CommentFileSizeAuthor
#4 interdiff.txt1.52 KByched
#4 2418117-MenuLinkContent_default_value-4.patch1.52 KByched
#1 2418117-MenuLinkContent_default_value-1.patch1.29 KByched

Comments

yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new 2418117-MenuLinkContent_default_value-1.patch1.29 KB

Patch

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Alright :)

yched’s picture

yched commented
Title: MenuLinkContent::baseFieldDefinitions() wrongly passes default values as a field setting, » MenuLinkContent::baseFieldDefinitions() wrongly passes default values as a field setting
yched’s picture

yched commented
StatusFileSize
new 2418117-MenuLinkContent_default_value-4.patch1.52 KB
new interdiff.txt1.52 KB

Added the one that slipped in #2417423: Re-process the user-entered-paths for custom menu links when there is a menu rebuild

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks, yched!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I thought it might be a duplicate of #2417809: link and shortcut have baseFieldDefinition settings that do not do anything: default_value max_length, but that already got in. RTBC +1 :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed b5b8da9 on 8.0.x 
    Issue #2418117 by yched: MenuLinkContent::baseFieldDefinitions() wrongly...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yesct’s picture

yesct commented

I'm curious why we couldn't have a test that would have caught this.