Leftover from #2417793-10: Allow entity: URIs to be entered in link fields :

+++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
@@ -219,19 +231,34 @@ public function validateTitle(&$element, FormStateInterface $form_state, $form)
+  protected function getUserEnteredStringAsUri($uri) {

getFooAsBar($bar) is a bit weird - that $uri param is not a URI yet, that's the whole point :-)
--> s/$uri/$string/ ?

CommentFileSizeAuthor
#4 interdiff.txt552 bytesyched
#4 2418109-LinkWidget_getUserEnteredStringAsUri-3.patch1.2 KByched
#1 2418109-LinkWidget_getUserEnteredStringAsUri-1.patch1.15 KByched

Comments

yched’s picture

yched commented
StatusFileSize
new 2418109-LinkWidget_getUserEnteredStringAsUri-1.patch1.15 KB

Patch

yched’s picture

yched commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

This is a good idea IMHO

yched’s picture

yched commented
StatusFileSize
new 2418109-LinkWidget_getUserEnteredStringAsUri-3.patch1.2 KB
new interdiff.txt552 bytes

Wow, that was quick :-)

Actually, forgot one instance in the phpdoc.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

+1 for RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 03f372f on 8.0.x 
    Issue #2418109 by yched: Misleading param name in LinkWidget::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.