ConfigImportAllTest tries to enable all available modules.

When running the test locally, this also includes whatever contrib modules might be present on the site. Meaning, you don't run what the testbot runs.

The test should limit itself to core modules ?

CommentFileSizeAuthor
#6 interdiff.txt866 bytesyched
#6 2417817-ConfigImportAllTest_core_only-6.patch1000 bytesyched
#1 2417817-ConfigImportAllTest_core_only-1.patch805 bytesyched

Comments

yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new 2417817-ConfigImportAllTest_core_only-1.patch805 bytes

patch

yched’s picture

yched commented

Easy RTBC ?

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Very easy :)

yched’s picture

yched commented

:-)

Along the same line : #2417839: Add code to ease debugging of ConfigImportAllTest fails

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented 
+++ b/core/modules/config/src/Tests/ConfigImportAllTest.php
@@ -53,7 +53,7 @@ public function testInstallUninstall() {
       // Filter hidden, already enabled modules and modules in the Testing
       // package.

This comment needs update now.

yched’s picture

yched commented
StatusFileSize
new 2417817-ConfigImportAllTest_core_only-6.patch1000 bytes
new interdiff.txt866 bytes

Oops, indeed :-)

Just a comment fix, as the interdiff shows, so keeping at RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

So I'm ambivalent about this change. On one hand it means that modules laying around in your checkout don't influence test results and you run on the same code base as testbot - otoh - we've had this pattern with d7 and d8 for the module install/enable/uninstall/disable test. And if you get failures then it exposes bugs in those modules.

yched’s picture

yched commented

A test should have a fixed scope as to what it tests ?
It's really weird that some test passes on the testbot and fails locally because of some stuff that happens to lie around on my disk outside the core/ folder ?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Well the scope in your codebase :) but I'm not that fussed and if it helps so that people won't moan about this test then yay. Committed 3207072 and pushed to 8.0.x. Thanks!

  • alexpott committed 3207072 on 8.0.x 
    Issue #2417817 by yched: Keep contrib modules out of ConfigImportAllTest

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.