Problem/Motivation

While working on #1481148: Simpletest does not consider form items of type 'button' for submitting forms I found a reference to DrupalWebTestCase. This class has been renamed to WebTestBase in #1541676: Convert Simpletest base test classes to PSR-0.

TestBase::prepareDatabasePrefix() line 1017 .. 1022

The generated database table prefix is used for the Drupal installation
   * being performed for the test. It is also used as user agent HTTP header
   * value by the cURL-based browser of DrupalWebTestCase, which is sent to the
   * Drupal installation of the test. During early Drupal bootstrap, the user
   * agent HTTP header is parsed, and if it matches, all database queries use
   * the database table prefix that has been generated here.

Proposed resolution

Update the documentation to refer to the renamed class. This is the only reference currently in HEAD that refers to the old class.

Remaining tasks

  • Write a patch
  • Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#2 2417515-2.patch1.11 KBidebr

Comments

idebr’s picture

idebr commented
Issue summary: View changes

Removed emphasis, since it does not work in php blocks.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 2417515-2.patch1.11 KB

Attached patch fixes the documentation. I updated the docblock line breaks to fill the maximum of 80 chars per line.

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Good find @idebr.
The DrupalWebTestCase is replaced with WebTestBase and a documentation change has been forgotten.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a518f9d and pushed to 8.0.x. Thanks!

  • alexpott committed a518f9d on 8.0.x 
    Issue #2417515 by idebr: TestBase::prepareDatabasePrefix() refers to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.