Follow up from #2415757: Remove all uses of file_get_mimetype

Problem/Motivation

#2415757: Remove all uses of file_get_mimetype removed usages of file_get_mimetype, let's remove the function itself here.

Proposed resolution

Remove function file_get_mimetype($uri, $mapping = NULL)

API changes

Remove file_get_mimetype()

Remaining tasks

Review patch.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue priority Normal as the patch removes a no longer used, already deprecated, function
Prioritized changes code already marked for removal by 8.0.0
CommentFileSizeAuthor
#7 remove-file_get_mimetype-function-2417071-7.patch1.36 KBchintan.vyas
#1 remove-file_get_mimetype-function-2417071-1.patch1.35 KBchintan.vyas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chintan.vyas’s picture

chintan.vyas CreditAttribution: chintan.vyas commented
Status: Postponed » Needs review
FileSize
remove-file_get_mimetype-function-2417071-1.patch1.35 KB

Removed file_get_mimetype function.

chintan.vyas’s picture

chintan.vyas CreditAttribution: chintan.vyas commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 1: remove-file_get_mimetype-function-2417071-1.patch, failed testing.

Status: Needs work » Needs review

mondrake queued 1: remove-file_get_mimetype-function-2417071-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: remove-file_get_mimetype-function-2417071-1.patch, failed testing.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Issue tags: +Needs reroll
chintan.vyas’s picture

chintan.vyas CreditAttribution: chintan.vyas commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
remove-file_get_mimetype-function-2417071-7.patch1.36 KB

Rerolling..

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Issue summary: View changes

Added beta evaluation

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Status: Needs review » Reviewed & tested by the community

Looks good to go. Thanks @chintan.vyas.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 6a88305 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 6a88305 on 8.0.x 
    Issue #2417071 by chintan.vyas: Remove file_get_mimetype

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.