When editing a Views widget, there is a stray select box (with "H2" in it by default) at the bottom of the dialog. It looks like it's meant to allow choosing the title element, but it's taken into account by panopoly_magic (or something somewhere) and gets lost. :-)

CommentFileSizeAuthor
#7 panopoly_magic-stray-select-box-2416781-7.patch578 bytesdsnopek
Selection_009.png31.55 KBdsnopek

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented

Looks like this is specific to that block only.
admin/structure/pages/nojs/operation/page-panopoly_demo_panel/handlers/page_panopoly_demo_panel_panel_context/content?destination=demo

Anonymous’s picture

Anonymous (not verified) commented

If you uncheck the "title" at admin/structure/views/view/panopoly_demo/edit in the "allow settings" options the h2 disappears. So it looks like rendering of the title override is placed outside the edit-display-settings fieldset. Most likely it is due to changed name of the element or something in that way.

---

In the views_content_views_panes_content_type_edit_form there is not setting for the title override at all and it was not in there before ctools update either so this has to be comming from somewhere else. Maybe form alter.

----

In

profiles/panopoly/modules/panopoly/panopoly_widgets/panopoly_widgets.views_default.inc:141
profiles/panopoly/modules/panopoly/panopoly_search/panopoly_search.views_default.inc:115
profiles/panopoly/modules/panopoly/panopoly_search/panopoly_search.views_default.inc:233

the title_override option is enabled and it looks to me like this was added/changed but somebody has forgot to also add this into the mentioned views_content_views_panes_content_type_edit_form.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Priority: Normal » Critical

Thanks for investigating! I think the bug is in panopoly_magic, specifically in panopoly_magic_form_views_content_views_panes_content_type_edit_form_alter(). It re-arranges the form for Views-based widgets, and it doesn't know about this new field so it leaves it behind.

Marking as Critical because I think this should block the next release (ie. we have to fix it before we can release).

Anonymous’s picture

Anonymous (not verified) commented

Also see
views_content_views_panes_content_type_render
views_content_views_panes_add_defaults
views_content_views_panes_content_type_edit_form
views_content_views_panes_content_type_edit_form_submit

in profiles/panopoly/modules/contrib/ctools/views_content/plugins/content_types/views_panes.inc

Seems as purely CTools bug so I think we should change project for this issue to ctools.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Well, even if it's a CTools bug, we need a Panopoly issue to track adding the patch to Panopoly.

So, like I suggested on #2416775: Warning: Illegal offset type in views_add_contextual_links() (line 816 of ~/prj/panopoly/panopoly/modules/contrib/views/views.module), if you've got a CTools patch then open a NEW issue there and reference it from this issue. Then we can put a patch on this issue which adds that patch to the .make file.

Thanks for all your work on this! :-)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
StatusFileSize
new panopoly_magic-stray-select-box-2416781-7.patch578 bytes

I'm going to use this patch to panopoly_magic to fix. We're hiding the rest of the override_title_* fields so hiding this one seems in line with what we're already doing.

@ivanjaros: If there is still a CTools bug, please open a new issue in the CTools queue and post a comment here with a link to it. Thanks!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

  • dsnopek committed 242c9e2 on 7.x-1.x 
    Update Panopoly Magic for Issue #2416781 by dsnopek, ivanjaros: Stray...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.