Warning: Illegal offset type in views_add_contextual_links() (line 816 of ~/prj/panopoly/panopoly/modules/contrib/views/views.module) [#2416775]

I'm not sure the cause of this, but I've started seeing this message recently on my Panopoly test sites.

I did a tiny amount of debugging: apparently the $view in question is the panopoly_demo view, and the $display_id (which isn't being found) is an Array() rather than a proper id (the Array looks like the body field, which is just weird).

I looked at the backtrace for a second and it's coming through Panels - probably one of the Views on the homepage. Not sure what change could have caused this - maybe something new in the views_content module in CTools?

Comment	File	Size	Author
#1	2416775-ctools_wrong_argument_for_views_add_contextual_links.patch	589 bytes	Anonymous (not verified)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 30 January 2015 at 09:40

Status:

Active

» Needs work

File	Size
2416775-ctools_wrong_argument_for_views_add_contextual_links.patch	589 bytes

This issue comes from ctools and therefore it should be moved there but I am leaving it under panopoly for now just so we know about the solution.

FYI: the issue is caused by the foreach loop that uses $display as a name for the value which overrides the already existing $display in the function since foreach will not destroy the variable name(s) after its done.

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 30 January 2015 at 09:41

Status:

Needs work

» Needs review

Comment #3

dsnopek

he/him

English

USA

CreditAttribution: dsnopek commented 30 January 2015 at 13:11

@ivanjaros: Thanks! The patch works for me. Can you open a new issue in CTools and then reference that issue from here? We can then make this issue about applying that CTools patch in our .make file.

Comment #4

dsnopek

he/him

English

USA

CreditAttribution: dsnopek commented 30 January 2015 at 13:29

Priority:

Normal

» Critical

Marking as Critical because I think this should block the next release (ie. we have to fix it before we can release).

Comment #5

dsnopek

he/him

English

USA

CreditAttribution: dsnopek commented 2 February 2015 at 20:19

To move things along, I created a new issue in the CTools queue with @ivanjaros' patch:

#2416589: Warning: Illegal offset type en views_add_contextual_links()

I'll get it into Panopoly shortly!

Comment #6

dsnopek

he/him

English

USA

CreditAttribution: dsnopek commented 2 February 2015 at 20:23

Status:

Needs review

» Fixed

Committed!

Comment #7

2 February 2015 at 20:24

dsnopek committed 9d1015e on 7.x-1.x

Update Panopoly Core for Issue #2416775 by ivanjaros: Warning: Illegal...

Comment #8

16 February 2015 at 20:24

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #9

labboy0276 CreditAttribution: labboy0276 commented 19 June 2015 at 14:47

I am seeing this error again, Panopoly 1.22 Modules installed. We don't have the whole profile installed, just panopoly_core, panopoly_images, panopoly_theme, panopoly_widgets, panopoly_wysiwyg.

Ctools is at 1.7 && views is at 3.11. I can make it going away by changing line 848 of views.module from:

if (empty($view->hide_admin_links)) {

if (empty($view->hide_admin_links) && isset($view->display[$display_id])) {

But that seems to just apply a bandaid to the situation.

Error message
Notice: Undefined offset: 1 in views_add_contextual_links() (line 852 of /srv/bindings/fcb6965abad846c9bb18a68343700aa3/code/sites/all/modules/contrib/views/views.module).
Notice: Trying to get property of non-object in views_add_contextual_links() (line 852 of /srv/bindings/fcb6965abad846c9bb18a68343700aa3/code/sites/all/modules/contrib/views/views.module).
Notice: Undefined offset: 1 in metatag_views_post_render() (line 2072 of /srv/bindings/fcb6965abad846c9bb18a68343700aa3/code/sites/all/modules/contrib/metatag/metatag.module).
Notice: Trying to get property of non-object in metatag_views_post_render() (line 2076 of /srv/bindings/fcb6965abad846c9bb18a68343700aa3/code/sites/all/modules/contrib/metatag/metatag.module).