Problem/Motivation

That attribute causes an HTML5 validator to mark this as an error as the alt attribute mustn't be used on input elements. See here:

Besides that the i'm not sure why the id attribute is set explicitly, however if done so it should be done using '#id' => 'id' and a drupal coding style compatible name (not camel case but use dashes between words).

Proposed resolution

Remove alt attribute and correct id attribute as proposed above.

CommentFileSizeAuthor
#3 remove-alt-attribute-from-donate-submit-btn-2416547-3.interdiff.txt938 bytess_leu
#3 remove-alt-attribute-from-donate-submit-btn-2416547-3.patch1.4 KBs_leu
#1 remove-alt-attribute-from-donate-submit-btn-2416547-1.patch726 bytess_leu
Screenshot from 2015-01-29 16:37:18.png123.37 KBs_leu

Comments

s_leu’s picture

s_leu commented
Status: Active » Needs review
StatusFileSize
new remove-alt-attribute-from-donate-submit-btn-2416547-1.patch726 bytes

Here's a first patch that fixes this.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I'm not sure why the alt is there, but it is likely that we've built this to reflect the salsa form as much as possible, as it submits directly to salsa and maybe that is needed to work with their validation.

s_leu’s picture

s_leu commented
StatusFileSize
new remove-alt-attribute-from-donate-submit-btn-2416547-3.patch1.4 KB
new remove-alt-attribute-from-donate-submit-btn-2416547-3.interdiff.txt938 bytes

Found two more issues with id attributes. Also as we discussed, there is no functionality related to that invalid alt attribute, so i'm leaving this in the patch.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Yeah, committed.

  • Berdir committed fe82be6 on 7.x-1.x authored by s_leu 
    Issue #2416547 by s_leu: Remove obsolete alt attribute on submit button...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.