Follow-up to #2408653: Remove lists.css from Bartik, add it's current code directly to the components it references.

Problem/Motivation

list.css was removed from Bartik here #2408653: Remove lists.css from Bartik, add it's current code directly to the components it references..
We changed the files ckeditor uses here #2064379: Remove ckeditor-iframe.css and load relevant Bartik CSS files for CKEditor's iframe mode. which was committed first but we failed to pick up on this as part of the work in the list.css issue.

Proposed resolution

We need to remove the file declaration under ckeditor in the info file and fix the corresponding test.

Remaining tasks

Write a patch.
Review the patch.

User interface changes

None, we are cleaning up.

API changes

n/a

Beta phase evaluation

-->

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because it is work missing from another issue that has been committed that is causing a 404 error in core now.
Unfrozen changes Unfrozen because it is taking out something leftover that is causing an error in core, this issue only fixes a bug.
CommentFileSizeAuthor
#1 bartik-remove-listcss-2415855-1.patch1.34 KBemma.maria

Comments

emma.maria’s picture

emma.maria
she/her
commented
Status: Active » Needs review
StatusFileSize
new bartik-remove-listcss-2415855-1.patch1.34 KB

Here's the patch...

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Reviewed & tested by the community

Tested this in the parent issue. Seemed to fix the problem. Beta evaluation is also there!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: bartik-remove-listcss-2415855-1.patch, failed testing.

idebr’s picture

idebr commented
Status: Needs work » Needs review

idebr queued 1: bartik-remove-listcss-2415855-1.patch for re-testing.

emma.maria’s picture

emma.maria
she/her
commented
Status: Needs review » Reviewed & tested by the community

Testbot had a wobbly putting back to RTBC again.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ec7b144 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed ec7b144 on 
    Issue #2415855 by emma.maria: A forgotten reference to list.css in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.