Shortcuts not sorted on display

Looks good, I agree doing the sort in getShortcuts is a better solution then what I came up with.
Test looks good also.

+++ b/core/modules/shortcut/src/Entity/Shortcut.php
@@ -183,4 +183,21 @@ public function getCacheTags() {
+  public static function sort(array &$shortcuts) {

Wouldn't it look better if we put this in the ShortcutSet class?

The $shortcuts array passed to the new sort() method is basically a shortcut set. Isn't it semantically correct that we're sorting a set of shortcuts, hence ShortcutSet::sort()?

By the reasoning in #12, should we move getShortcuts() to the Shortcut class as well?

Shouldn't new sort() function just contain the comparison function and the uasort be done in getShortcuts().

Something like this:

public static function sort(ShortcutInterface $a, ShortcutInterface $b) {
  $a_weight = $a->getWeight();
  $b_weight = $b->getWeight();
  if ($a_weight == $b_weight) {
    return strnatcasecmp($a->getTitle(), $b->getTitle());
  }
  return ($a_weight < $b_weight) ? -1 : 1;
}

and then getShortcuts() should be this

public function getShortcuts() {
  $shortcuts = \Drupal::entityManager()->getStorage('shortcut')->loadByProperties(array('shortcut_set' => $this->id()));
  uasort($shortcuts, array('\Drupal\shortcut\Entity\Shortcut', 'sort'));
  return $shortcuts;
}

This seems more consistent with what other core modules are doing.

As discussed.

+++ b/core/modules/shortcut/src/Entity/Shortcut.php
@@ -186,18 +186,23 @@ public function getCacheTags() {
+   * @param array $a
+   *   First item for comparison.
+   * @param array $b
+   *   Second item for comparison.

These are ShortcutInterface objects, not arrays :)

Cool, thanks!

Committed/pushed to 8.0.x, thanks!

HURRAY! Shortcut Sanity!