This issue is for adding the @Event tag and appropriate documentation to the following list of events.
$this->eventDispatcher->dispatch(LanguageConfigOverrideEvents::DELETE_OVERRIDE, new LanguageConfigOverrideCrudEvent($this));
$this->eventDispatcher->dispatch(LanguageConfigOverrideEvents::SAVE_OVERRIDE, new LanguageConfigOverrideCrudEvent($this));
This documentation should include the following information:
- What the event is
- What it is used for
- What kind of $event object is passed along.
- @see links to related classes (event class, representative class where event is dispatched, representative class where event is subscribed to).
Beta eval: This is API documentation, so unfrozen. Also very low disruption possibility.
See the parent issue for a documentation template, and more information: #2382169: [meta] Add @Event to all events defined by drupal core
Comments
Comment #1
eojthebraveHere is a first pass at the documentation for these events.
Comment #2
eojthebraveComment #3
jhodgdonForgot the @Event tags. Doh! :)
The docs look good though. Thanks!
Comment #4
nitvirus commentedComment #5
nitvirus commentedHello,
Updated the patch, just added the : @Event at line number 13 and 28.
Thank,
Nit
Comment #6
jhodgdonLooks good, thanks for the patch!
In the future:
a) When you upload a patch to an issue, set the issue status to "needs review". This will alert people and also launch the test bot.
b) When you upload a new patch that builds on a previous patch, also make an interdiff file. See https://www.drupal.org/documentation/git/interdiff for instructions. This is a small patch though, so I was able to review it without the interdiff -- so don't bother at this point.
Comment #7
jhodgdonComment #8
webchickYay, docs! :)
Committed and pushed to 8.0.x. Thanks!
Comment #10
nitvirus commentedOk @jhodgdon,
Got the point. Would keep this is mind. Thanks for the help. Would keep these in mind next time I post a patch.
Thanks,
Nit