Follow-up to #2386585: Upgrade to Symfony 2.6.1 and #2377281: Upgrade to Symfony 2.6 stable.

Symfony 2.6.4 is out. I think we should upgrade since we are tracking stables. This is critical as this is an external library upgrade. Please downgrade if minor version upgrades are not really critical. This should be a quickfix, so I don't think there would be a problem.

Note: From the changelog, it seems there are security related fixes/improvements which may or may not be applicable to us. But it is still a good idea to update.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it is an external library upgrade.
Issue priority Critical because this is an external library upgrade.
Disruption Not disruptive.
CommentFileSizeAuthor
#11 interdiff.txt1.51 KBdawehner
#11 2414235-11.patch636.37 KBdawehner
#4 upgrade_to_symfony_2_6_3-2414235-4.patch734.27 KBhussainweb
#1 upgrade_to_symfony_2_6_3-2414235-1.patch668.32 KBhussainweb

Comments

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new upgrade_to_symfony_2_6_3-2414235-1.patch668.32 KB

Attaching updates after running composer update symfony/*. There is no need to change composer.json here.

hw@d8:/var/www/d8task/core-[git 8.0.x] $ composer update symfony/*
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing symfony/class-loader (v2.6.1)
  - Installing symfony/class-loader (v2.6.3)
    Loading from cache

  - Removing symfony/css-selector (v2.6.1)
  - Installing symfony/css-selector (v2.6.3)
    Loading from cache

  - Removing symfony/dependency-injection (v2.6.1)
  - Installing symfony/dependency-injection (v2.6.3)
    Loading from cache

  - Removing symfony/debug (v2.6.1)
  - Installing symfony/debug (v2.6.3)
    Loading from cache

  - Removing symfony/http-foundation (v2.6.1)
  - Installing symfony/http-foundation (v2.6.3)
    Loading from cache

  - Removing symfony/event-dispatcher (v2.6.1)
  - Installing symfony/event-dispatcher (v2.6.3)
    Loading from cache

  - Removing symfony/http-kernel (v2.6.1)
  - Installing symfony/http-kernel (v2.6.3)
    Loading from cache

  - Removing symfony/routing (v2.6.1)
  - Installing symfony/routing (v2.6.3)
    Loading from cache

  - Removing symfony/serializer (v2.6.1)
  - Installing symfony/serializer (v2.6.3)
    Loading from cache

  - Removing symfony/translation (v2.6.1)
  - Installing symfony/translation (v2.6.3)
    Loading from cache

  - Removing symfony/validator (v2.6.1)
  - Installing symfony/validator (v2.6.3)
    Loading from cache

  - Removing symfony/process (v2.6.1)
  - Installing symfony/process (v2.6.3)
    Loading from cache

  - Removing symfony/yaml (v2.6.1)
  - Installing symfony/yaml (v2.6.3)
    Loading from cache

Writing lock file
Generating autoload files
catch’s picture

catch
he/him
Primary language English
commented
Priority: Critical » Major

Per #2400407: [meta] Ensure vendor (PHP) libraries are on latest stable release minor releases are critical.

However this is a patch-level release so shouldn't be. The reasons to not have patch-level releases as critical are that they may not have relevant changes for us, or only normal/minor bug fixes,a nd also it should be straightforward to skip a patch-level release and go to the next one once it's out.

So downgrading to major. If there's something in this release that should independently be a release blocker, we should upgrade it again.

And of course it's still good to keep up to date even if the issue isn't critical.

hussainweb’s picture

hussainweb
Primary language English
commented
Related issues: +#2375339: Update DependencyInjection YamlFileLoader for Symfony 2.6

... or only normal/minor bug fixes,a nd also it should be straightforward to skip a patch-level release and go to the next one once it's out.

Agreed on this. I think we can still go ahead with this update on priority to keep the subsequent upgrades even smaller. And it will be good to stay on top of those minor/normal bugs as well. :)

I know this is essentially what you are saying but I am just making a point that keeping it critical can sometimes move a quickfix release like this very quickly. I have no problems with this being major as well. This was just a running thought.

Lastly, I am just marking an issue that does depend on this (not blocked, just affected).

hussainweb’s picture

hussainweb
Primary language English
commented
Title: Upgrade to Symfony 2.6.3 » Upgrade to Symfony 2.6.4
Issue summary: View changes
StatusFileSize
new upgrade_to_symfony_2_6_3-2414235-4.patch734.27 KB

Symfony 2.6.4 is out.

hw@d8:/var/www/d8task/core-[git 8.0.x] $ composer update symfony/*
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing symfony/class-loader (v2.6.1)
  - Installing symfony/class-loader (v2.6.4)
    Loading from cache

  - Removing symfony/css-selector (v2.6.1)
  - Installing symfony/css-selector (v2.6.4)
    Loading from cache

  - Removing symfony/dependency-injection (v2.6.1)
  - Installing symfony/dependency-injection (v2.6.4)
    Downloading: 100%

  - Removing symfony/debug (v2.6.1)
  - Installing symfony/debug (v2.6.4)
    Downloading: 100%

  - Removing symfony/http-foundation (v2.6.1)
  - Installing symfony/http-foundation (v2.6.4)
    Downloading: 100%

  - Removing symfony/event-dispatcher (v2.6.1)
  - Installing symfony/event-dispatcher (v2.6.4)
    Downloading: 100%

  - Removing symfony/http-kernel (v2.6.1)
  - Installing symfony/http-kernel (v2.6.4)
    Downloading: 100%

  - Removing symfony/routing (v2.6.1)
  - Installing symfony/routing (v2.6.4)
    Downloading: 100%

  - Removing symfony/serializer (v2.6.1)
  - Installing symfony/serializer (v2.6.4)
    Downloading: 100%

  - Removing symfony/translation (v2.6.1)
  - Installing symfony/translation (v2.6.4)
    Loading from cache

  - Removing symfony/validator (v2.6.1)
  - Installing symfony/validator (v2.6.4)
    Downloading: 100%

  - Removing symfony/process (v2.6.1)
  - Installing symfony/process (v2.6.4)
    Downloading: 100%

  - Removing symfony/yaml (v2.6.1)
  - Installing symfony/yaml (v2.6.4)
    Downloading: 100%

Writing lock file
Generating autoload files

Status: Needs review » Needs work

The last submitted patch, 4: upgrade_to_symfony_2_6_3-2414235-4.patch, failed testing.

hussainweb’s picture

hussainweb
Primary language English
commented

A minor upgrade shouldn't break anything. This doesn't look like an usual random failure but there is a chance. It could also be a sign of broken HEAD, but I don't see the same failures in other patches around this time.

I think we should retest this just once to make sure.

Status: Needs work » Needs review

hussainweb queued 4: upgrade_to_symfony_2_6_3-2414235-4.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: upgrade_to_symfony_2_6_3-2414235-4.patch, failed testing.

hussainweb’s picture

hussainweb
Primary language English
commented
Priority: Major » Critical

It looks like a valid test failure. If this is a breakage/regression, this should be a critical issue to resolve immediately rather than waiting for next major release.

I can't debug through this today, but will try tonight or tomorrow. Feel free to downgrade this if it doesn't look like a critical issue.

dawehner’s picture

dawehner
Primary language German
commented

Wow, I'll try to see which commit in symfony caused that

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2414235-11.patch636.37 KB
new interdiff.txt1.51 KB

It seems to be for me that we have a wrong setup for this 2 tests.

If you request a site on the frontpage using a subdir installation the path is indeed "/subdir/" but our tests assumed "/subdir".

https://github.com/symfony/symfony/pull/13039 was the corresponding symfony issue.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Triaged D8 critical

NIce work tracking the upgrades and the fix.

This also contains https://github.com/symfony/symfony/pull/13262 which helps with #1920902: Add a Drupal Yaml wrapper so we can default to PECL Yaml component if it is available.

RTBC for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1003720 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 1003720 on 8.0.x 
    Issue #2414235 by hussainweb, dawehner: Upgrade to Symfony 2.6.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.