Avoid overwriting title of IPE buton

Thanks!

Please refrain from including whitespace or coding style fixes in unrelated code. While we'd like to fix these issues one day, committing this could prevent other patches to panopoly_magic from applying. Once the number of open patches is low enough, we'll make a "coding style pass" and fix all these issues at once. :-)

+++ b/panopoly_magic.module
@@ -1238,7 +1238,9 @@
-          $vars['buttons'][$panel_context_id][$button_name]['#title'] = t('Customize this page');
+          if (empty($vars['buttons'][$panel_context_id][$button_name]['#title'])) {
+            $vars['buttons'][$panel_context_id][$button_name]['#title'] = t('Customize this page');
+          }
           break;

Hrm. Unfortunately, I don't think that array key is ever going to be empty, so that code will never run. :-/

Also, I'm not entirely sure that code is necessary in the first place because the panels_ipe is already setting that button title to "Customize this page". The second one is necessary because the default is "Change layout" (without "this").

However, if the goal is for your preprocess function to take precedence over panopoly_magic's, you can reorder the preprocess functions using hook_theme_registry_alter():

https://api.drupal.org/api/drupal/modules%21system%21system.api.php/func...

By doing that in your module, you can avoid patching Panopoly all together!

I tried to track down the reasoning for that preprocess function and it comes from the initial commit of panopoly_magic. I'll e-mail @populist to see if he remembers why that's there, but personally, I'd be for removing the function entirely! All it does is add a "this" to "Change this layout", which is a suspect change at best. :-)

I believe that function was added by the chief (@merlinofchaos) as part of an effort to make the IPE bar more themeable - https://www.drupal.org/node/1249332. We added the function to Panopoly Magic to match the original designs.

No worries from me if we want to remove the logic to make Panopoly more extendable, as long as the default labels are human friendly.

Thanks, @populist!

Yeah, the default labels are almost the same except "Change this layout" is "Change layout" which I think is totally fine. Here is a patch that removes the preprocess and lets the default labels shine through! I'll make sure our automated tests still work and then commit.

Here's the Travis-CI build:

https://travis-ci.org/dsnopek/panopoly/builds/47827626

Tests passed! Thanks to @Chewie for pushing this and @populist for the background info! Committed. :-)

Moving to Panopoly issue queue... Not sure how this got here!