Hi Fred, noticed as small error in the file ctools_export_ui_osf_configure_datasets.class.php
Around line 240 the $base_dir was missing because it was not set Global.
Perhaps add global at line 200 and then the one at line 223 can be removed.

Hope this helps, sorry I've never mastered the trick of making patches, perhaps should start to learn that.

Cheers, Roen

CommentFileSizeAuthor
#2 osf-changes-2410901.patch11.22 KBroeneman

Comments

roeneman’s picture

roeneman commented

Hi Fred, another small issue but leading to not getting the list of classes in "osf/entities/ontologies/sync/classes"

The default for the variable get for the search interface name could be set to "default". So:

variable_get("osf_searchapi_settings_interface_name", 'default')

Changes could be made to the following files:
osf\modules\osf_entities\osf_entities.admin.inc
osf\modules\osf_entities\osf_entities.module (5x)
osf\modules\osf_fieldstorage\osf_fieldstorage.admin.inc (3x)
osf\modules\osf_field\osf_field.module
osf\modules\osf_searchapi\osf_searchapi.module

Hope this helps.
Cheers,
Roen

roeneman’s picture

roeneman commented
Status: Active » Needs review
StatusFileSize
new osf-changes-2410901.patch11.22 KB

Hi Fred, I've tried to make a patch, first time ever so please review critically.
It has a number of smaller fixes too.

Hope this helps.
Cheers,
Roen

fgiasson’s picture

fgiasson commented

Thanks for the patch!

I never neither, I would really prefer working this stuff using forking like GitHub, would make contributions much easier to manage! :)

Before I start integrating this stuff, would it be possible for you to split that patch in 3: one for each issue you created? That would be easier to follow what is what and to modify some of them if required.

Thanks!

Fred

roeneman’s picture

roeneman commented

Hi, it does look like a lot, that patch, doesn't it. But really its all just little changes and enhancements, I hoped this would help you but apparently it does not. Sorry for that.

fgiasson’s picture

fgiasson commented

No, it is not a problem, but normally it is a patch per issue (that get fixed with the patch). That way, if we want to improve the fix, this doesn't impact other reported issues.

is this something you could do?

fgiasson’s picture

fgiasson commented
Status: Needs review » Closed (won't fix)

I close this ticket until I get the split.