Problem/Motivation

The 'people' icon is missing from the toolbar. This is probably due to the new collections added in #2401505: Add an entity collection template for lists , since the new class on the menu item is called toolbar-icon-entity-user-collection

Proposed resolution

Reintroduce the 'People' icon.

Remaining tasks

  • Write a patch
  • Attach screenshot
  • Review

User interface changes

The 'People' menu item has an icon again.

API changes

None

Screenshot before

CommentFileSizeAuthor
#6 2410441-6.patch849 bytesidebr
#6 interdiff-6-2.txt682 bytesidebr
#2 2410441-2.patch578 bytesidebr
people-icon-missing.png104.18 KBidebr

Comments

idebr’s picture

idebr commented
Issue summary: View changes
idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 2410441-2.patch578 bytes

Attached patch updates the css selector to the new class.

idebr’s picture

idebr commented 
+++ b/core/modules/user/user.routing.yml
@@ -43,7 +43,7 @@ entity.user.admin_form:
-user.admin_account:
+entity.user.collection:

The change in #2401505: Add an entity collection template for lists that caused the issue.

Status: Needs review » Needs work

The last submitted patch, 2: 2410441-2.patch, failed testing.

olli’s picture

olli commented 
+++ b/core/modules/toolbar/css/toolbar.icons.css
@@ -101,7 +101,7 @@
 .toolbar-icon-user-admin-account:active:before,

Here's another one that needs the same change.

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-6-2.txt682 bytes
new 2410441-6.patch849 bytes

Ah yes, of course. Thanks olli :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Sorry :)

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Tested manually and both the 'inactive' and 'active' variants of the People icon show up now.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2410441-6.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Filter by username returned the right amount. Other UserAdminTest.php 69 Drupal\user\Tests\UserAdminTest->testUserAdmin()

Second time I've seen that in a few days.

Status: Needs work » Needs review

Berdir queued 6: 2410441-6.patch for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2410441-6.patch, failed testing.

Status: Needs work » Needs review

idebr queued 6: 2410441-6.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: 2410441-6.patch, failed testing.

Status: Needs work » Needs review

Berdir queued 6: 2410441-6.patch for re-testing.

idebr’s picture

idebr commented
Status: Needs review » Reviewed & tested by the community

Setting back to RTBC per #8 and #12.

manuel garcia’s picture

manuel garcia commented

Just tested the patch manually, and this is very much RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Normal » Major
Status: Reviewed & tested by the community » Fixed

That's a pretty nasty user-facing bug, so raising to major.

Committed and pushed to 8.0.x. Thanks!

steveoliver’s picture

steveoliver commented

@webchick, I just noticed this bug, found this issue, and checked commit log ... Don't see it. Did you push? :)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Fixed » Reviewed & tested by the community

I'll bet @webchick pushed, but either it conflicted or #1089672: Fatal error while perfoming git push to drupal.org Git repositories happened.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed fb65eb3 and pushed to 8.0.x. Thanks!

  • alexpott committed fb65eb3 on 8.0.x 
    Issue #2410441 by idebr: 'People' icon missing from toolbar
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Blah! :( Thanks folks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.