I get this error when I'm trying to access /update.php: 

Can not clear module.minimal key in immutable configuration core.extension. Use \Drupal\Core\Config\ConfigFactoryInterface::getEditable() to retrieve a mutable configuration object in Drupal\Core\Config\ImmutableConfig->clear()
CommentFileSizeAuthor
#7 2410123-7-use-mutable-config.patch2.56 KBjeqq
#3 2410123-3-use-mutable-config.patch2.55 KBjeqq
use-mutable-config.patch572 bytesjeqq

Comments

jeqq’s picture

jeqq commented
Parent issue: » #2392319: Config objects (but not config entities) should by default be immutable
amateescu’s picture

amateescu commented
Status: Needs review » Needs work
Issue tags: +Needs tests

The patch looks good but it looks like we're missing tests for this functionality.

jeqq’s picture

jeqq commented
Status: Needs work » Needs review
StatusFileSize
new 2410123-3-use-mutable-config.patch2.55 KB

Added test.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

The patch is really simple and straight forward. Looks good to me.

I'd also consider this at least Major priority given the criticality of a broken update.php.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Issue tags: -Needs tests
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/system/src/Tests/Update/CompatibilityFixTest.php
@@ -0,0 +1,48 @@
+class CompatibilityFixTest extends WebTestBase {

This can be KernelTestBase test.

jeqq’s picture

jeqq commented
Status: Needs work » Needs review
StatusFileSize
new 2410123-7-use-mutable-config.patch2.56 KB

Thanks for the review @dixon_, @alexpott.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 74eed0e and pushed to 8.0.x. Thanks!

  • alexpott committed 74eed0e on 8.0.x 
    Issue #2410123 by jeqq: Use mutable configuration to fix compatibility...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.