Problem/Motivation

When you are logged out and you want to request a new password you will be redirected to the login page, with just a little message in the top window that says "Further instructions have been sent to your email address." In my opinion it's illogical to redirect to the login page, because the user can't log in, and the e-mail doesn't provide you a username and password, but a link, so you never need the login page in this scenario. I rather see a full page explanation about receicing an e-mail with a link to login.

Proposed resolution

"just set this to go to the front page, keeping the same message as before" has UX approval as per #10. No additional test coverage seems to be needed.

Remaining tasks

User interface changes

Redirect to homepage instead of user login page.

API changes

None

Original report by @MsG

Comments

msg’s picture

Issue tags: +SprintWeekend2015
msg’s picture

Issue summary: View changes
stevenpatz’s picture

Assigned: Unassigned » stevenpatz
Status: Active » Needs review
StatusFileSize
new548 bytes

I've just set this to go to the front page, keeping the same message as before.

roya-rateshtari’s picture

Status: Needs review » Reviewed & tested by the community

I tested the patch and it worked as expected.

xjm’s picture

Priority: Minor » Normal
Status: Reviewed & tested by the community » Needs review

Thanks @MsG, @Roya-Rateshtari, and @StevenPatz, for the patch, review, and screenshots. I've always found this minorly annoying and confusing as well. I wondered if redirecting to the front page made sense, but I think it does. We don't want the user to end up back on the same form because that will confuse users as to whether the form has actually been submitted.

This issue was already tagged for a usability review, so setting back to NR for that signoff, but I think this is a good usability improvement.

manauwarsheikh’s picture

StatusFileSize
new36.84 KB

Yes, I agree.
When a user request for "Reset Password" then the message should appear on the homepage "Further instructions have been sent to your email address." instead of showing login page again. And currently it is working for me.(attached screenshot)

manauwarsheikh’s picture

Status: Needs review » Reviewed & tested by the community
manjit.singh’s picture

Issue tags: +SrijanSprintDay
xjm’s picture

Status: Reviewed & tested by the community » Needs review

@manauwarsheikh, thanks for testing! Per #5, a usability maintainer's signoff was requested for this issue (the "Needs usability review" issue tag was added to it at some point), which is why I set it to "Needs review." Restoring that status. :)

Bojhan’s picture

Version: 8.0.x-dev » 8.1.x-dev
Issue tags: -Needs usability review

Makes sense, might need a re-test to see if this still works.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

roderik’s picture

Status: Needs review » Reviewed & tested by the community

It still works. Now I hope this doesn't need a usability re-review after 5 years ;-)

(I do not know how stringent we are in requiring automated tests for everything; this change might not need a test to verify that we end up at the front page?)

quietone’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll, +Novice, +Needs issue summary update, +Bug Smash Initiative

Oh, this is nice, I like this improvement. @roderik, thanks for giving this a nudge.

The patch does not apply to 9.2.x, so needs a reroll, adding tag. It look suitable for a novice, so adding tag.

The resolution in the Issue Summary does not match the patch, so the IS needs an update. This too is suitable for a novice.

Thx

quietone’s picture

Assigned: stevenpatz » Unassigned

I think it is safe to un-assign StevenPatz .

anushrikumari’s picture

Assigned: Unassigned » anushrikumari
anushrikumari’s picture

Assigned: anushrikumari » Unassigned
Status: Needs work » Needs review
StatusFileSize
new565 bytes

Rerolled patch #3 for 9.2.x

Status: Needs review » Needs work

The last submitted patch, 25: 2409657-25.patch, failed testing. View results

ressa’s picture

Status: Needs work » Needs review
StatusFileSize
new42.35 KB

This is a great idea, and the patch applies and works fine, sending the user to the front page after requesting a password reset:

Password reset on front

The test seems to fail though ...

ressa’s picture

Status: Needs review » Needs work

Updating status.

roderik’s picture

Status: Needs work » Reviewed & tested by the community

Sorry for not being diligent; I just applied the patch manually to my local 9.2.x before testing, and it worked with a line difference of about 35. (And I thought tests which were still 'green', were running automatically every so often.)

The failing test (FunctionalJavascript\LayoutBuilderQuickEditTest) seemed like a fluke / unrelated to me; after having pressed the "retest" button on #25 it's now green. So this is tested.

roderik’s picture

Issue summary: View changes
roderik’s picture

Related issue which could be used (or closed as duplicate) if we want to backport to D7...

alexpott’s picture

Version: 9.2.x-dev » 9.1.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5cb4fa9112 to 9.2.x and 61307db3bb to 9.1.x. Thanks!

Backported to 9.1.x as this is a usability improvement with little risk.

  • alexpott committed 5cb4fa9 on 9.2.x
    Issue #2409657 by anushrikumari, StevenPatz, MsG, manauwarsheikh, ressa...

  • alexpott committed 61307db on 9.1.x
    Issue #2409657 by anushrikumari, StevenPatz, MsG, manauwarsheikh, ressa...
stevenpatz’s picture

Glad to see this get in. Not sure why it was 'safe' to remove me. But anyway, it's merged.

quietone’s picture

@StevenPatz, apologies, I didn't explain that. I meant that since you haven't work on this issue since May 2015, it seemed OK to unassign you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.