Found two instances of misleading wording in Views advanced settings:

  • "Hide block if the view output is empty: Hide | Show"

    Options should read: Yes | No
  • Query settings: "Disabling SQL rewriting will disable node_access checks as well as other modules that implement hook_query_alter()."

    Rewrite required since this option does not disable any modules.

I will provide a patch.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Bug, the existing help texts are confusing
Issue priority Normal, because the actual problem isn't breaking any behaviour
Unfrozen changes Unfrozen because of only string changes.
Disruption No disruption
CommentFileSizeAuthor
#8 amend_misleading_views-2409623-8.patch1.91 KBAnonymous (not verified)
#1 amend_misleading_ui_wording-2409623-1.patch1.91 KBhexabinaer

Comments

hexabinaer’s picture

hexabinaer
Location Berlin, Germany
commented
Status: Active » Needs review
Issue tags: +SprintWeekend2015
StatusFileSize
new amend_misleading_ui_wording-2409623-1.patch1.91 KB
rogerpfaff’s picture

rogerpfaff
he/his
Primary language German
Location Munich
commented
Status: Needs review » Reviewed & tested by the community

The changes are fine.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: amend_misleading_ui_wording-2409623-1.patch, failed testing.

Status: Needs work » Needs review

tobiasb queued 1: amend_misleading_ui_wording-2409623-1.patch for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Can we change node_access to node access while we're there?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

re #6 - I think yes let's do that.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new amend_misleading_views-2409623-8.patch1.91 KB

Just removing the underscore right?

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Yeah, thank you for fixing it.
@pjonckiere ... still always try to provide an interdifff, if possible.

Added a beta eval.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 11a81a4 on 8.0.x 
    Issue #2409623 by hexabinaer, pjonckiere, tstoeckler: Amend misleading...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.