Suggested commit message

git commit -m 'Issue #2409577 by katzilla, k4v: Allow to enter the machine name in the views filter'

Problem/Motivation

If you search on admin/structure/views you'll just find the title of the view, not the machine name. This is really annoying if you know the machine name already.

Proposed resolution

Expand the test search.

Remaining tasks

User interface changes

You can type "user" on /admin/structure/views and it works.

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue priority Normal, its a little bit annoying
Unfrozen changes Unfrozen because it only changes the templates
Prioritized changes The main goal of this issue is usability.
Disruption Not disruptive
CommentFileSizeAuthor
#15 machine-name-in-views-filter-translatable-2409577-11.patch707 bytespfarc
#11 machine_name_in_views_filter-2409577-9.patch616 byteskatzilla
#8 machine-name-in-views-filter-translatable-2409577-8.patch3.15 KBpfarc
#2 machine_name_in_views_filter-2409577-1.patch589 byteskatzilla

Comments

pfarc’s picture

pfarc commented
Assigned: Unassigned » pfarc
katzilla’s picture

katzilla
she/her
Primary language German
Location Göttingen, Germany
commented
StatusFileSize
new machine_name_in_views_filter-2409577-1.patch589 bytes

Committed Patch. Machine name now visible and searchable.

dawehner’s picture

dawehner
Primary language German
commented
Assigned: pfarc » Unassigned
Category: Task » Bug report
Issue summary: View changes
Status: Active » Reviewed & tested by the community

Too good to be true :) Even tested it manually ...

Afaik this is also a bug.

Added a beta evaluation.

nod_’s picture

nod_
Primary language French
Location Lille
commented

How do we translate that?

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
commented
Status: Reviewed & tested by the community » Needs work
k4v’s picture

k4v commented
Assigned: Unassigned » k4v

.

k4v’s picture

k4v commented
Issue summary: View changes
pfarc’s picture

pfarc commented
StatusFileSize
new machine-name-in-views-filter-translatable-2409577-8.patch3.15 KB

Here another solution which is translatable.

The last submitted patch, 2: machine_name_in_views_filter-2409577-1.patch, failed testing.

nod_’s picture

nod_
Primary language French
Location Lille
commented

Why the change in those other places?

katzilla’s picture

katzilla
she/her
Primary language German
Location Göttingen, Germany
commented
StatusFileSize
new machine_name_in_views_filter-2409577-9.patch616 bytes

Lets do it in twig template...

katzilla’s picture

katzilla
she/her
Primary language German
Location Göttingen, Germany
commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Yeah I prefer the twig template version as well.

katzilla’s picture

katzilla
she/her
Primary language German
Location Göttingen, Germany
commented
Issue tags: +Random test failure

We think that the patch at number #2 is a random test failure, so let's add the tag.

pfarc’s picture

pfarc commented
StatusFileSize
new machine-name-in-views-filter-translatable-2409577-11.patch707 bytes

fixed my first patch, sry for that : )

pfarc’s picture

pfarc commented
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

for everyone's info, the patch that is rtbc is #11

k4v’s picture

k4v commented

@alexpott: katzilla and me were working on this together on the sprint weekend.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c1b07da and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed c1b07da on 8.0.x 
    Issue #2409577 by katzilla, pfaendler, k4v: Allow to enter the machine...
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Opened a small follow-up.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Oops, meant to link it here, sorry for the noise: #2415079: Slight visual improvement for the machine name on the views overview

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.