Add missing RTL css for the Tour dialog

This problem is in tour module css.
Please review and validate this patch that solve the problem.

@vacho Don't forget to update the issue status to 'Needs review' when you upload a patch :)

@balagan You are correct, the selector was off. The close-button is now on the correct side, but the padding from .joyride-tip-guide and .joyride-content-wrapper is still missing RTL css. Let's add that while we're at it.

Yes, looking good! Just a few small things:

1. +++ b/core/modules/tour/css/tour.module.css
   @@ -60,7 +60,11 @@
   +  padding: 1em 1em 1.5em 1.5em; /* LTR */
   +}
   +
   +[dir="rtl"] .joyride-tip-guide {
   +  padding: 1em 1.5em 1.5em 1em;
   

   There is no need for an additional line breaks. RTL theming should go as close as possible to the original selector to increase readability

2. +++ b/core/modules/tour/css/tour.module.css
   @@ -69,6 +73,11 @@
   +[dir="rtl"] .joyride-content-wrapper {
   +  /* Apply padding from parent .joyride-tip-guide to absolutely positioned children. */
   

   An identical comment is two lines up. No need to repeat, so this line can be removed :)

3. +++ b/core/modules/tour/css/tour.module.css
   @@ -69,6 +73,11 @@
   +  padding-left: 1em;
   

   Don't forget to reset the padding-right that applied in the LTR styling (eg. padding-right: 0;)

Good solutions...
but I answer. The x (Close icon) in the view is at upper right corner on all windows popup interfaces of view.

Then are all popus of view also incorrect?

@vacho The Views dialogs have the close button on the wrong side indeed. This is being fixed in #2396473: Add missing RTL rules to System CSS

Patch looks good! Screenshot before:

Screenshot after:

Nice collaboration on this issue.

What about the "pager"?

Should the word 'of' be between the numbers?

Seems like patch doing more than just the close button. So I think this needs a more accurate title and an issue summary update.

The browser plug in from http://dreditor.org has some buttons that might help for using the issue summary template and embedding screen shots.

I did some additional testing on the pager and it appears this behavior is the default behavior for RTL. Additional changes:

• Updated the issue summary to correctly reflect the changes in the patch
• Added a beta evaluation

1. +++ b/core/modules/tour/css/tour.module.css
   @@ -68,6 +71,10 @@
      padding-right: 1em;
   

   Missing /* LTR */

2. +++ b/core/modules/tour/css/tour.module.css
   @@ -138,8 +145,10 @@
   +
   

   No need for additional blank line

+++ b/core/modules/tour/css/tour.module.css
@@ -68,6 +71,10 @@
+[dir="rtl"] .joyride-content-wrapper {
+  padding-right: 0;
+  padding-left: 1em; /* LTR */
+}

I think you misplaced the /* LTR */ comment here. It should be on the LTR styling instead.

The removed linebreak looks good:)

Could you add an interdiff to make it easier for reviewers to check your changes between patches? There is a documentation page available here: https://www.drupal.org/documentation/git/interdiff

Nice :). I added an interdiff with the last RTBC patch in #13 for easier reviewing

Committed 17bf38b and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.