Adjust context definitions of data_convert action

I will give it a try. Its a bit more complex than the action i ported before.

https://github.com/fago/rules/pull/129

My first try to create a first version of the port.

My pull request is still open. The last problem i tried to solve was to introduce an exception that handles wrong context parameters. How can we get some progress on it?

Thanks. This looks good now, there is just a class that needs to be removed then it can be merged. See my comment on github.

The PR is https://github.com/fago/rules/pull/129 - which has been updated by dermario. giuseppeib just updated the issue for him - I'm looking into this now though.

Picked it up and completed it on the way (wanted to merge it and found issues while doing so). Changes:
- Fixed data types to match d8
- Added missing todos
- rounding behaviour requires a conversion to integers

Setting back to needs work though as there is one todo left we can address in another PR: The context definitions needs to be changed depending on the target type context being set on the object.

#2456829: Context definition needs to be updated before execution is done - see EntityFetchByField as example. So this can be picked up.

@Fago,

Updated data_convert action. Setting the coversion_result's type to the target's type from context definition.

PR: https://github.com/fago/rules/pull/285

The pull request has some unrelated fixes in rules.module, can you remove that change and also extend the test case to cover the refining of the context?

I re-rolled #11 as a PATCH and removed the unrelated (and already fixed) changes that were mentioned in #13. Posting here so the testbot can test it and so others can review this issue.

I have not evaluated whether this completely addresses the @todo from #9, but the patch does seem consistent with the work done in #10.

Corrected function signature.

Here's a new patch that removes the @todo comment, adds a test for the new refineContextDefinitions() method, and adds asserts to the existing tests to check that the context type of the provided variable matches the target_type.

I think this is ready to be committed? Sure would be nice to get some feedback, as this is one of the last tasks that needs completing for #2269577: [META] Port all actions to 8.x.

Committed #17.