CommentFileSizeAuthor
#114 2887099-7.patch12.96 KBnaveenvalecha
#112 2870465-8.patch38.99 KBnaveenvalecha
#110 2870465-8.patch39.76 KBnaveenvalecha
#108 2870465-8.patch38.15 KBnaveenvalecha
#106 2870465-8.patch30.12 KBnaveenvalecha
#104 2872059-10.patch18.98 KBnaveenvalecha
#101 2864005-7.patch7.06 KBnaveenvalecha
#100 2863607-15.patch3.88 KBnaveenvalecha
#97 2872059-8.patch17.96 KBnaveenvalecha
#95 2872059-8.patch16.89 KBnaveenvalecha
#93 2854543-23.patch6.07 KBnaveenvalecha
#92 2755401-14-2.patch11.23 KBnaveenvalecha
#90 2755401-14-1.patch11.76 KBnaveenvalecha
#88 2755401-14.patch11.72 KBnaveenvalecha
#87 2749873-43-2.patch7.73 KBnaveenvalecha
#87 2749873-43.patch7.25 KBnaveenvalecha
#84 2863607-9.patch6.44 KBnaveenvalecha
#83 2831274-389.patch255.64 KBnaveenvalecha
#82 2831274-389.patch255.66 KBnaveenvalecha
#81 2831274-379-abc.patch253.87 KBnaveenvalecha
#79 2389335-18.patch81.72 KBnaveenvalecha
#78 2324871-67-2.patch11.78 KBnaveenvalecha
#76 2083649-43-3.patch20.31 KBnaveenvalecha
#74 2083649-43-2.patch17.74 KBnaveenvalecha
#73 2324877-7-2.patch6.39 KBnaveenvalecha
#72 2428003-28-2.patch7.06 KBnaveenvalecha
#71 2806983-20-2.patch2.11 KBnaveenvalecha
#69 2806983-20-1.patch0 bytesnaveenvalecha
#66 2742995-22.patch16.17 KBnaveenvalecha
#64 2742995-22.patch16.81 KBnaveenvalecha
#63 306662-208-1.patch19.94 KBnaveenvalecha
#61 2743197-34.patch7.62 KBnaveenvalecha
#59 2743197-33.patch7.54 KBnaveenvalecha
#56 2743197-32.patch5.44 KBnaveenvalecha
#55 2743197-31.patch70.13 KBnaveenvalecha
#54 306662-172-test.patch30.27 KBnaveenvalecha
#52 2408985-52.patch15.86 KBnaveenvalecha
#51 interdiff-2408985-306662-145-150.txt4.03 KBnaveenvalecha
#51 2408985-306662-150.patch18.07 KBnaveenvalecha
#50 interdiff-2408985-306662-145-150.txt4.06 KBnaveenvalecha
#50 2408985-306662-150.patch18.1 KBnaveenvalecha
#48 interdiff-306662-136-138.txt2.31 KBnaveenvalecha
#48 interdiff-306662-131-138.txt4.33 KBnaveenvalecha
#48 306662-138.patch19.31 KBnaveenvalecha
#46 306662-138.patch19.26 KBnaveenvalecha
#45 2408985-306662-122-2.patch16.24 KBnaveenvalecha
#43 2408985-306662-122.patch16.24 KBnaveenvalecha
#42 2408985-306662-122.patch0 bytesnaveenvalecha
#41 2408985-107-2.patch14.42 KBnaveenvalecha
#39 2408985-306662-107.patch15.04 KBnaveenvalecha
#38 2408985-306662-109.patch16.85 KBnaveenvalecha
#37 2408985-306662-108.patch16.86 KBnaveenvalecha
#35 306662-108.patch15.8 KBnaveenvalecha
#33 interdiff-2408985-106-108.txt614 bytesnaveenvalecha
#33 2408985-108.patch14.41 KBnaveenvalecha
#31 306662-108-3.patch13.73 KBnaveenvalecha
#29 2408985-106-1.patch14.08 KBnaveenvalecha
#26 306662-109.patch14.11 KBnaveenvalecha
#22 306662-108.patch13.2 KBnaveenvalecha
#21 306662-107.patch12.17 KBnaveenvalecha
#20 306662-106.patch12.17 KBnaveenvalecha
#18 306662-104.patch12.18 KBnaveenvalecha
#16 306662-104.patch11.91 KBnaveenvalecha
#14 306662-104.patch11.92 KBnaveenvalecha
#12 306662-104.patch11.92 KBnaveenvalecha
#9 306662-104.patch11.82 KBnaveenvalecha
#8 306662-104.patch17.75 KBnaveenvalecha
#7 2304461-193.patch84.3 KBnaveenvalecha
#6 jenkins-project-deployment.png83.53 KBnaveenvalecha
#6 jenkins-console-output.png161.64 KBnaveenvalecha
#6 jenkins-listing.png247.19 KBnaveenvalecha
#5 added-new-line-at-end-2513626.patch481 bytesnaveenvalecha
#4 added-new-line-at-end-2513626.patch513 bytesnaveenvalecha
#3 tadityar Drupal.org_.png68.65 KBnaveenvalecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha’s picture

FileSize
68.65 KB
naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

Adding some images to include on https://www.drupal.org/node/968454

naveenvalecha’s picture

FileSize
84.3 KB
naveenvalecha’s picture

Version: 8.0.x-dev » 8.1.x-dev
FileSize
17.75 KB
naveenvalecha’s picture

Another shot after git pull

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
11.92 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
11.92 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
11.91 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
12.18 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
12.17 KB
naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

Status: Needs work » Needs review

fixed testSiteWideContact tests

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
14.08 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
13.73 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
14.41 KB
614 bytes
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
15.8 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
16.86 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
16.85 KB
naveenvalecha’s picture

naveenvalecha’s picture

Status: Needs work » Needs review
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
14.42 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
0 bytes
naveenvalecha’s picture

The last submitted patch, 42: 2408985-306662-122.patch, failed testing.

naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

Status: Needs work » Needs review

interdiff-306662-136-138.txt
its the diff b/w #46 and #48 in this thread

+++ b/core/modules/contact/contact.install
@@ -13,7 +13,9 @@
-    $contact->setRedirectPath($page_front);
-    $contact->save();
+    if ($contact->getRedirectPath()) {
+      $contact->setRedirectPath($page_front);
+      $contact->save();
+    }

Why I have to explicitly add the check here for fixing this config ? I investigated but did not find the exact answer.
https://www.drupal.org/pift-ci-job/156314

naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

naveenvalecha’s picture

naveenvalecha’s picture

first start

naveenvalecha’s picture

fix the patch with some changes.converted teh test to kernel test base
KernelTestBase will not remain in simpletest after 8.2.x #2734663: Update deprecation message for old KernelTestBase in simpletest :( so Moving to unit tests

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
7.54 KB

Status: Needs review » Needs work

The last submitted patch, 59: 2743197-33.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
7.62 KB

ouch wrong diff earlier

Status: Needs review » Needs work

The last submitted patch, 61: 2743197-34.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
19.94 KB
naveenvalecha’s picture

Straight reroll

Status: Needs review » Needs work

The last submitted patch, 64: 2742995-22.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
16.17 KB

Status: Needs review » Needs work

The last submitted patch, 66: 2742995-22.patch, failed testing.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
0 bytes

Status: Needs review » Needs work

The last submitted patch, 69: 2806983-20-1.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
2.11 KB
naveenvalecha’s picture

FileSize
7.06 KB
naveenvalecha’s picture

FileSize
6.39 KB
naveenvalecha’s picture

FileSize
17.74 KB

Status: Needs review » Needs work

The last submitted patch, 74: 2083649-43-2.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
20.31 KB

Status: Needs review » Needs work

The last submitted patch, 76: 2083649-43-3.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
11.78 KB
naveenvalecha’s picture

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

naveenvalecha’s picture

FileSize
253.87 KB
naveenvalecha’s picture

FileSize
255.66 KB
naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

Status: Needs review » Needs work

The last submitted patch, 84: 2863607-9.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
7.25 KB
7.73 KB
naveenvalecha’s picture

Status: Needs review » Needs work

The last submitted patch, 88: 2755401-14.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
11.76 KB

Status: Needs review » Needs work

The last submitted patch, 90: 2755401-14-1.patch, failed testing. View results

naveenvalecha’s picture

naveenvalecha’s picture

FileSize
6.07 KB

Status: Needs review » Needs work

The last submitted patch, 93: 2854543-23.patch, failed testing. View results

naveenvalecha’s picture

FileSize
16.89 KB
naveenvalecha’s picture

Status: Needs work » Needs review
naveenvalecha’s picture

The last submitted patch, 95: 2872059-8.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 97: 2872059-8.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
3.88 KB
naveenvalecha’s picture

The last submitted patch, 100: 2863607-15.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 101: 2864005-7.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
18.98 KB

Status: Needs review » Needs work

The last submitted patch, 104: 2872059-10.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
30.12 KB

Status: Needs review » Needs work

The last submitted patch, 106: 2870465-8.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
38.15 KB

Removing
1) Drupal\Tests\user\Functional\UserRegistrationTest should be Javascript test. drupalPostAjaxForm

Status: Needs review » Needs work

The last submitted patch, 108: 2870465-8.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
39.76 KB

Status: Needs review » Needs work

The last submitted patch, 110: 2870465-8.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
38.99 KB

Don't convert UserBlocksTest because setRawContent is not available in the BTB yet

Status: Needs review » Needs work

The last submitted patch, 112: 2870465-8.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
12.96 KB

Status: Needs review » Needs work

The last submitted patch, 114: 2887099-7.patch, failed testing. View results

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dpi’s picture

Status: Needs work » Closed (won't fix)