Files: 

Comments

naveenvalecha’s picture

FileSize
68.65 KB
naveenvalecha’s picture

FileSize
513 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 97,376 pass(es). View
naveenvalecha’s picture

FileSize
481 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 97,410 pass(es). View
naveenvalecha’s picture

Adding some images to include on https://www.drupal.org/node/968454

naveenvalecha’s picture

FileSize
84.3 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 98,007 pass(es). View
naveenvalecha’s picture

Version: 8.0.x-dev » 8.1.x-dev
FileSize
17.75 KB
naveenvalecha’s picture

Another shot after git pull

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
11.92 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
11.92 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
11.91 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
12.18 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
12.17 KB
naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

Status: Needs work » Needs review

fixed testSiteWideContact tests

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
14.08 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
13.73 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
14.41 KB
614 bytes
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
15.8 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
16.86 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
16.85 KB
naveenvalecha’s picture

naveenvalecha’s picture

Status: Needs work » Needs review
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
14.42 KB
naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
0 bytes
naveenvalecha’s picture

The last submitted patch, 42: 2408985-306662-122.patch, failed testing.

naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

Status: Needs work » Needs review

interdiff-306662-136-138.txt
its the diff b/w #46 and #48 in this thread

+++ b/core/modules/contact/contact.install
@@ -13,7 +13,9 @@
-    $contact->setRedirectPath($page_front);
-    $contact->save();
+    if ($contact->getRedirectPath()) {
+      $contact->setRedirectPath($page_front);
+      $contact->save();
+    }

Why I have to explicitly add the check here for fixing this config ? I investigated but did not find the exact answer.
https://www.drupal.org/pift-ci-job/156314

naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

naveenvalecha’s picture

naveenvalecha’s picture

first start

naveenvalecha’s picture

fix the patch with some changes.converted teh test to kernel test base
KernelTestBase will not remain in simpletest after 8.2.x #2734663: Update deprecation message for old KernelTestBase in simpletest :( so Moving to unit tests

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
7.54 KB

Status: Needs review » Needs work

The last submitted patch, 59: 2743197-33.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
7.62 KB

ouch wrong diff earlier

Status: Needs review » Needs work

The last submitted patch, 61: 2743197-34.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
19.94 KB
naveenvalecha’s picture

Straight reroll

Status: Needs review » Needs work

The last submitted patch, 64: 2742995-22.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
16.17 KB

Status: Needs review » Needs work

The last submitted patch, 66: 2742995-22.patch, failed testing.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
0 bytes

Status: Needs review » Needs work

The last submitted patch, 69: 2806983-20-1.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
2.11 KB
naveenvalecha’s picture

FileSize
7.06 KB
naveenvalecha’s picture

FileSize
6.39 KB
naveenvalecha’s picture

FileSize
17.74 KB

Status: Needs review » Needs work

The last submitted patch, 74: 2083649-43-2.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
20.31 KB

Status: Needs review » Needs work

The last submitted patch, 76: 2083649-43-3.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
11.78 KB
naveenvalecha’s picture

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

naveenvalecha’s picture

FileSize
253.87 KB
naveenvalecha’s picture

FileSize
255.66 KB
naveenvalecha’s picture

naveenvalecha’s picture

naveenvalecha’s picture

Status: Needs review » Needs work

The last submitted patch, 84: 2863607-9.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
7.25 KB
7.73 KB
naveenvalecha’s picture

Status: Needs review » Needs work

The last submitted patch, 88: 2755401-14.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
11.76 KB

Status: Needs review » Needs work

The last submitted patch, 90: 2755401-14-1.patch, failed testing. View results

naveenvalecha’s picture

naveenvalecha’s picture

FileSize
6.07 KB

Status: Needs review » Needs work

The last submitted patch, 93: 2854543-23.patch, failed testing. View results

naveenvalecha’s picture

FileSize
16.89 KB
naveenvalecha’s picture

Status: Needs work » Needs review
naveenvalecha’s picture

The last submitted patch, 95: 2872059-8.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 97: 2872059-8.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
3.88 KB
naveenvalecha’s picture

The last submitted patch, 100: 2863607-15.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 101: 2864005-7.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
18.98 KB

Status: Needs review » Needs work

The last submitted patch, 104: 2872059-10.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
30.12 KB

Status: Needs review » Needs work

The last submitted patch, 106: 2870465-8.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
38.15 KB

Removing
1) Drupal\Tests\user\Functional\UserRegistrationTest should be Javascript test. drupalPostAjaxForm

Status: Needs review » Needs work

The last submitted patch, 108: 2870465-8.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
39.76 KB

Status: Needs review » Needs work

The last submitted patch, 110: 2870465-8.patch, failed testing. View results

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
38.99 KB

Don't convert UserBlocksTest because setRawContent is not available in the BTB yet

Status: Needs review » Needs work

The last submitted patch, 112: 2870465-8.patch, failed testing. View results