Error on language negotiation page (/admin/config/regional/language/detection) after clicking "Save settings" button.
Fatal error: Cannot access protected property Drupal\block\Entity\Block::$id in /home/s1a7d8dae28761cf/www/core/modules/language/src/Form/NegotiationConfigureForm.php on line 337
TBD
N/A
N/A
| Issue category | Bug due to fatal error |
|---|---|
| Issue priority | Major because this fatal error can be produced through the UI |
| Unfrozen changes | Unfrozen because it only changes code to not throw a fatal error |
| Prioritized changes | The main goal of this issue is a bug fix. |
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 2408977-15-complete.patch | 2.67 KB | geertvd |
| #15 | 2408977-15-test.patch | 1.92 KB | geertvd |
| #12 | 2408977-12.patch | 794 bytes | geertvd |
Comments
Comment #1
kristen polComment #2
kristen polComment #3
kristen polComment #4
kristen polComment #5
unstatu commentedComment #6
unstatu commentedCannot reproduce. Tried to get the error by doing some changes in the detection configuration, but I got no errors.
Steps followed:
1- Installed a standard Drupal 8
2- Enabled the Language module
3- Acceded to /admin/config/regional/language/detection
4- Enabled and disabled the detection methods randomly
5- Clicked to 'Save settings'
Comment #7
unstatu commentedComment #8
develcuy commentedComment #9
develcuy commentedRemoved SprintWeekend2015Queue by mistake.
Comment #10
kristen polThis happened when I was testing a particular D8MI patch... let me see if I can figure out which one and can reproduce.
Comment #11
kristen polI'm not able to find the patch I was testing that caused this to happen so closing this.
Comment #12
geertvd commentedI got the same error and found this issue.
This is caused by #2030571: Expand Block with methods which created getters and setters for the Black class and changed the public $id property to a protected one.
Simple fix: just call the getter instead of directly calling the property.
Comment #13
geertvd commentedI think this can be a major
Comment #14
webchickPatch looks fine, but let's get an automated test so we don't accidentally re-introduce errors in this code path again.
Comment #15
geertvd commentedAdded test and changed the original patch.
Instead of matching on id which is the block's machine name and configurable by the user I'm matching on the pluginId instead.
Comment #21
jhedstromThis now has tests illustrating the issue, and the fix.
I think the change to use the plugin ID makes sense, and the code is easier to understand.
I've updated the issue summary to include a beta phase evaluation.
Comment #22
alexpottNice work. Committed ffea3bb and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.