When creating a float field, max and min value settings are forced to be integer

The UI or storage?

The issue occurs at the field UI level. It happens when creating a new field (Decimal or float) or editing the field ui settings. The problem happens for Default Value, Min and Max Value.

Also, when creating the field for the first time, the system does not validate if the default value is greater than the max value specified in the field ui settings. It does however validate during editing the field ui settings,

Hi,

I have created a patch. It works for me. Kindly review.

@amitsedaiz
Thank you for working on this issue.

We should all try and use the same sprint tag. According to https://groups.drupal.org/node/447258 it should be SprintWeekend2015 with no #.

Starting to work on this issue.

Moved logic for the redefinition of the form settings into FieldType/DecimalItem and FieldType/FloatItem.

I didn't find current tests for Fieldtypes in the code so I didn't add a new test case, probably it should be a complete test definition that should be covered in a new ticket?

Find some problems in the way we are representing decimal points in the UI, I'll create a new ticket for that.

@gloob
We can make a new issue to add more complete test coverage, but the bug for just this one part needs to have a test in *this* issue.

Try writing a test and stick it somewhere, reviews of the test will help improve any first try you do at it. :)

Didn't think an interdiff was necessary since I just added the test.

+++ b/core/modules/field/src/Tests/Number/NumberFieldTest.php
@@ -459,4 +459,38 @@ function testNumberFormatter() {
+    $this->assertNoRaw(t('%name is not a valid number.', array('%name' => t('Minimum'))), 'Saved decimal value as minimal value on a float field');
...
+    $this->assertNoRaw(t('%name is not a valid number.', array('%name' => t('Minimum'))), 'Saved integer value as minimal value on a float field');

This is a negative test and therefore very fragile - it should at least be accompanied by a positive assertion that what we expected to occur has occurred.

Something like this should cover that.

This issue fix two problems at once. The float field and decimal field. I would say we need additional test also for the decimal field.

Nice catch @gloob. Let's add a test for decimal too.

Added the decimal field test and a helper function to make it all a bit more readable

Looks good for me. Great job @geertvd! :-)

1. +++ b/core/modules/field/src/Tests/Number/NumberFieldTest.php
   @@ -477,28 +478,52 @@ function testCreateNumberFloatField() {
   +    // Set the minimum value to an decimal value.
   +    $this->setMinimumValue($field_type, $field_name, 0.1);
   

   Perhaps this should be a float like 0.0001 - something that would not work for a decimal field.

2. +++ b/core/modules/field/src/Tests/Number/NumberFieldTest.php
   @@ -477,28 +478,52 @@ function testCreateNumberFloatField() {
   +  /**
   +   * Helper function to set the minimum value of a field.
   +   */
   +  function setMinimumValue($field_type, $field_name, $minimum_value) {
   

   If this is called assertSetMinimumValue() simpletest will report a more useful line number..

3. +++ b/core/modules/field/src/Tests/Number/NumberFieldTest.php
   @@ -477,28 +478,52 @@ function testCreateNumberFloatField() {
        $this->drupalPostForm($field_configuration_url, $edit, t('Save settings'));
        // Check if an error message is shown.
   -    $this->assertNoRaw(t('%name is not a valid number.', array('%name' => t('Minimum'))), 'Saved integer value as minimal value on a float field');
   +    $this->assertNoRaw(t('%name is not a valid number.', array('%name' => t('Minimum'))), 'Saved ' . gettype($minimum_value) .'  value as minimal value on a ' . $field_type . ' field');
   

   Let's also assert some form of success message.

Changes suggested by @alexpott are implemented

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 0d15b2b and pushed to 8.0.x. Thanks!