See parent issue(s) and related issue(s) for details,

Twig Templates to Copy

  • core/modules/system/templates/links.html.twig
Files: 
CommentFileSizeAuthor
#7 issue-2407749-6.patch237 bytesolmaga
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,988 pass(es). View
#5 issue-2407749-5.patch241 bytesolmaga
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,976 pass(es), 14 fail(s), and 0 exception(s). View
#1 issue-2407749-1.patch2.61 KBSivaji
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,892 pass(es). View

Comments

Sivaji’s picture

Status: Active » Needs review
FileSize
2.61 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,892 pass(es). View
davidhernandez’s picture

It looks like this moves the one file unedited. Is that correct? If so, please adjust your Git settings.

See this page, https://www.drupal.org/documentation/git/configure

You'll see a section for Optimize diffs for renamed and copied files. When copying or renaming a file the patch will show a one line change for the copy/rename. This make it much easier to review, since the patch won't contain the contents of the file.

Sivaji’s picture

Thanks for the direction. I understand for the copied files I should get only reference in diff (with similarity index 100% copy from ... copy to ...) not the entire file content. I'm already using the ~/.gitconfig from https://www.drupal.org/documentation/git/configure and command git diff HEAD to make patches, not sure how to get patch having only reference of copied files.

olmaga’s picture

Assigned: Unassigned » olmaga
olmaga’s picture

FileSize
241 bytes
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,976 pass(es), 14 fail(s), and 0 exception(s). View

Sorry - This was a move

davidhernandez’s picture

They should all be copies. So the existing template will stay in place and a copy will be put in Classy.

olmaga’s picture

FileSize
237 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,988 pass(es). View

Here is the copy one:

emanuelrighetto’s picture

Status: Needs review » Reviewed & tested by the community

patch #7 work great IMHO! ;)

The last submitted patch, 5: issue-2407749-5.patch, failed testing.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Markup changes are not frozen in beta. Committed 2f540a0 and pushed to 8.0.x. Thanks!

  • alexpott committed 2f540a0 on 8.0.x
    Issue #2407749 by olmaga, sivaji@knackforge.com: Copy system templates l...
alexpott’s picture

Issue tags: +SprintWeekend2015
Sivaji’s picture

@davidhernandez, in response to comment #6, What is the git command (or configuration) I should have used to create the patch as in #7. I used git diff HEAD.

davidhernandez’s picture

@sivaji, if it isn't picking up the copy, try git diff -C

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.