See parent issue(s) and related issue(s) for details,

Twig Templates to Copy

  • core/modules/system/templates/links.html.twig
CommentFileSizeAuthor
#7 issue-2407749-6.patch237 bytesolmaga
#5 issue-2407749-5.patch241 bytesolmaga
#1 issue-2407749-1.patch2.61 KBsivaji_ganesh_jojodae

Comments

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Active » Needs review
StatusFileSize
new issue-2407749-1.patch2.61 KB
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented

It looks like this moves the one file unedited. Is that correct? If so, please adjust your Git settings.

See this page, https://www.drupal.org/documentation/git/configure

You'll see a section for Optimize diffs for renamed and copied files. When copying or renaming a file the patch will show a one line change for the copy/rename. This make it much easier to review, since the patch won't contain the contents of the file.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

Thanks for the direction. I understand for the copied files I should get only reference in diff (with similarity index 100% copy from ... copy to ...) not the entire file content. I'm already using the ~/.gitconfig from https://www.drupal.org/documentation/git/configure and command git diff HEAD to make patches, not sure how to get patch having only reference of copied files.

olmaga’s picture

olmaga commented
Assigned: Unassigned » olmaga
olmaga’s picture

olmaga commented
StatusFileSize
new issue-2407749-5.patch241 bytes

Sorry - This was a move

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented

They should all be copies. So the existing template will stay in place and a copy will be put in Classy.

olmaga’s picture

olmaga commented
StatusFileSize
new issue-2407749-6.patch237 bytes

Here is the copy one:

emanuelrighetto’s picture

emanuelrighetto commented
Status: Needs review » Reviewed & tested by the community

patch #7 work great IMHO! ;)

The last submitted patch, 5: issue-2407749-5.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Markup changes are not frozen in beta. Committed 2f540a0 and pushed to 8.0.x. Thanks!

  • alexpott committed 2f540a0 on 8.0.x 
    Issue #2407749 by olmaga, sivaji@knackforge.com: Copy system templates l...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +SprintWeekend2015
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

@davidhernandez, in response to comment #6, What is the git command (or configuration) I should have used to create the patch as in #7. I used git diff HEAD.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented

@sivaji, if it isn't picking up the copy, try git diff -C

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.