Remove classes from system templates m*.html.twig

Postponing this until we decide how we are moving forward. Keep an eye on #2348543: [meta] Consensus Banana Phase 2, transition templates to the starterkit theme for updates. Thanks.

Un-postponing. The templates have been copied to Classy, so all we need to do is remove classes from the original templates.

Looked through all files, and they render as intended.

looks like testboot was drunk setting this back to RTBC after tester from xen

Templates are not frozen in beta. Committed 2b9b727 and pushed to 8.0.x. Thanks!

This caused a visual regression in Seven's installer. It looks like the original maintenance-task-list.html.twig should have been copied to Classy. Follow-up created unless we want to revert: #2426589: Visual regression: Missing 'task-list' class in Seven installer

we want a followup ;)

I uploaded a patch in the issue Cottser linked to.

We should not have been changing maintenance-task-list.html.twig installer theming is not at all like regular theming. Revert this patch.

Alex, did you push that revert? I'm not picking it up.

Removing maintenance template from the patch.

maintenance-page.html.twig should still be cleaned up, whats beeing reverted is the maintenance-task-list.html.twig
Which we should rename in a followup issue to install-tast-list.html.twig or something like that to make sense

maintenance-task-list.html.twig is pulled of the patch

interdiff added

no visual regressions on installer

+++ b/core/modules/system/templates/maintenance-page.html.twig
@@ -21,15 +21,15 @@
       </div>{# /.name-and-slogan #}

@@ -47,13 +47,13 @@
     </aside>{# /.layout-sidebar-first #}
...
     </aside>{# /.layout-sidebar-second #}

We should remove these comments since they refer to the classes we are removing.

comments removed intediff added

Alright this now good to go. Double checked that all removed classes are still in classy, so we are safe when it comes to visual regressions.

Templates are not frozen in beta. Committed bc49133 and pushed to 8.0.x. Thanks!

How has this change not broken the toolbar that require .menu class?

Ahh classy kept the menu class.

That's a good catch @hass, if you switch your theme to Stark and navigate to the homepage you get a kinda broken toolbar. Not really this issue's fault, at this point I agree that toolbar shouldn't be using such a generic class name for both its CSS and especially not its JS. So it seems we need to add some classes back until #1944572: Remove "ul.menu" dependency to prevent theme clashes is resolved:

#2447829: Add "menu" classes back to menu.html.twig for toolbar functionality