Problem/Motivation

remove non essential classes from core/modules/system/templates/html.html.twig

Proposed resolution

Remaining tasks

User interface changes

API changes

Original report by @sivaji@knackforge.com

Files: 
CommentFileSizeAuthor
#4 remove_classes_from-2407729-4.patch892 bytesmortendk
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 86,891 pass(es). View
#1 issue-2407729-1.patch2.09 KBSivaji
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,942 pass(es). View

Comments

Sivaji’s picture

Status: Active » Needs review
FileSize
2.09 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,942 pass(es). View
davidhernandez’s picture

Status: Needs review » Postponed

Postponing this until we decide how we are moving forward. Keep an eye on #2348543: [meta] Consensus Banana Phase 2, transition templates to the Classy theme for updates. Thanks.

davidhernandez’s picture

Title: Copy system templates h*.html.twig to Classy » Remove classes from system templates h*.html.twig
Issue summary: View changes
Status: Postponed » Needs work

Un-postponing. The templates have been copied to Classy, so all we need to do is remove classes from the original templates.

mortendk’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
892 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 86,891 pass(es). View
davidhernandez’s picture

Status: Needs review » Reviewed & tested by the community

I don't see anything attached to the classes removed. The ones left are needed.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: remove_classes_from-2407729-4.patch, failed testing.

Status: Needs work » Needs review
LewisNyman’s picture

Status: Needs review » Reviewed & tested by the community

Back to RTBC

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Classy has a copy of this template and templates are not frozen in beta. Committed 232f5a5 and pushed to 8.0.x. Thanks!

  • alexpott committed 232f5a5 on 8.0.x
    Issue #2407729 by sivaji@knackforge.com, mortendk: Remove classes from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.