Followup to #2403729: Convert user_cancel_confirm() to a new-style Form object There is now only a single theme function in user.pages.inc. Lets move it to user.module and remove user.pages.inc

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Disruption This has zero disruption as no-one should be including user.pages.inc in their own code. This removes another include file.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kim.pepper’s picture

Status: Active » Needs review
FileSize
2.52 KB

Fixed.

Status: Needs review » Needs work

The last submitted patch, 1: 2407489-remove-user-pages-1.patch, failed testing.

kim.pepper’s picture

Status: Needs work » Needs review
FileSize
3.31 KB
980 bytes

Also remove references to user.pages.inc

kim.pepper’s picture

Hmm. Seems it's being used as an example of theme usage. Do we need to change that to a file that actually exists?

kim.pepper’s picture

Re-rolled after #2407493: Clean up use statements in user.module Rolled back the documentation change in theme.api.php. We can post a follow up for that.

kim.pepper’s picture

Removes unused $account variable.

jibran’s picture

Status: Needs review » Reviewed & tested by the community

Awesome thanks.

kim.pepper’s picture

Wim Leers’s picture

Issue tags: +Quickfix

Looks great; this simply moves code around.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update

This issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary. Eg. zero disruption, less includes, nothing should depend on this being there.

kim.pepper’s picture

Issue summary: View changes

Added beta evaluation.

jibran’s picture

Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs issue summary update

Back to RTBC.

kim.pepper’s picture

Issue summary: View changes
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed fd90b0b and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed fd90b0b on 8.0.x
    Issue #2407489 by kim.pepper: Remove user.pages.inc
    
iMiksu’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.