Followup to #2403729: Convert user_cancel_confirm() to a new-style Form object There is now only a single theme function in user.pages.inc. Lets move it to user.module and remove user.pages.inc
| Disruption | This has zero disruption as no-one should be including user.pages.inc in their own code. This removes another include file. |
|---|
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff.txt | 569 bytes | kim.pepper |
| #6 | 2407489-remove-user-pages-6.patch | 3.24 KB | kim.pepper |
| #5 | interdiff.txt | 1.46 KB | kim.pepper |
| #5 | 2407489-remove-user-pages-5.patch | 3.29 KB | kim.pepper |
| #3 | interdiff.txt | 980 bytes | kim.pepper |
Comments
Comment #1
kim.pepperFixed.
Comment #3
kim.pepperAlso remove references to user.pages.inc
Comment #4
kim.pepperHmm. Seems it's being used as an example of theme usage. Do we need to change that to a file that actually exists?
Comment #5
kim.pepperRe-rolled after #2407493: Clean up use statements in user.module Rolled back the documentation change in theme.api.php. We can post a follow up for that.
Comment #6
kim.pepperRemoves unused $account variable.
Comment #7
jibranAwesome thanks.
Comment #8
kim.pepperCreated followup #2408265: Update hook_theme_registry_alter to not reference removed user.pages.inc
Comment #9
wim leersLooks great; this simply moves code around.
Comment #10
alexpottThis issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary. Eg. zero disruption, less includes, nothing should depend on this being there.
Comment #11
kim.pepperAdded beta evaluation.
Comment #12
jibranBack to RTBC.
Comment #13
kim.pepperComment #14
alexpottCommitted fd90b0b and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.
Comment #16
imiksu