Pretty straight forward. Navigate to admin/reports/views-plugins and you'll get a white screen or a fatal error report depending on your error display settings.

Example:
Fatal error: Class 'Drupal\views_ui\Controller\Views' not found in /.../core/modules/views_ui/src/Controller/ViewsUIController.php on line 118

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug
Issue priority Not critical because this page is probably not used much.
Prioritized changes The main goal of this issue is a bug fix.
Disruption None
CommentFileSizeAuthor
#10 2406657-views-plugin-report-fatal-10.patch1.71 KBneclimdul
#10 interdiff-2406657-10.txt1.47 KBneclimdul
#7 views-plugin-report-fatal_2406657_7-SHOULDFAIL.patch924 byteslendude
#6 views-plugin-report-fatal.patch1.44 KBneclimdul
#5 views-plugin-report-fatal.patch1.42 KBneclimdul
views-plugin-report-fatal.patch552 bytesneclimdul

Comments

neclimdul’s picture

neclimdul
He/Him
commented

This seems to be the culprit

neclimdul’s picture

neclimdul
He/Him
commented
Related issues: +#2030667: Refactoring ViewStorageInterface to ViewEntityInterface
dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +VDC, +Needs tests

Ha I almost forgot that this page exists.

Would be nice to have at least some really rudimentary test coverage :)

dawehner’s picture

dawehner
Primary language German
commented

Maybe just go to the page and check a 200

neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new views-plugin-report-fatal.patch1.42 KB

With test. Failed appropriately without the previous patch locally.

neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new views-plugin-report-fatal.patch1.44 KB

gugh, got distracted and forgot the message on the assert. Apologies.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new views-plugin-report-fatal_2406657_7-SHOULDFAIL.patch924 bytes 
+++ b/core/modules/views_ui/src/Tests/ReportTest.php
@@ -0,0 +1,35 @@
+ * Contains \Drupal\views_ui\Tests\SettingsTest.

Needs to be set to the right class.

+++ b/core/modules/views_ui/src/Tests/ReportTest.php
@@ -0,0 +1,35 @@
+  /**
+   * Tests the settings for the edit ui.
+   */

Update this comment to reflect the test being done.

+++ b/core/modules/views_ui/src/Tests/ReportTest.php
@@ -0,0 +1,35 @@
+/**
+ * Tests all ui related settings under admin/structure/views/settings.
+ *

Update this comment.

+++ b/core/modules/views_ui/src/Tests/ReportTest.php
@@ -0,0 +1,35 @@
+    // Test the settings tab exists.

Update this comment.

Fix looks good and turns the test from red to green.

Will add a test-only patch, and make that set this to needs work.

Status: Needs review » Needs work

The last submitted patch, 7: views-plugin-report-fatal_2406657_7-SHOULDFAIL.patch, failed testing.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented 
+++ b/core/modules/views_ui/src/Tests/ReportTest.php
@@ -0,0 +1,35 @@
+class ReportTest extends UITestBase {

Also, using UITestBase sounds like a bit of overkill, maybe just use WebTestBase?

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2406657-10.txt1.47 KB
new 2406657-views-plugin-report-fatal-10.patch1.71 KB

Shameful copy paste errors... How about this?

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Looks good to me.

Added beta evaluation.

dawehner’s picture

dawehner
Primary language German
commented

Looks fine for me as well!

  • webchick committed 3b0178d on 8.0.x 
    Issue #2406657 by neclimdul, Lendude: Fatal error visiting Views Plugin...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch. Glad we have test coverage for this now!

Committed and pushed to 8.0.x. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +SprintWeekend2015

Retroactively tagging.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.