Now that we have proper link template support EntityDerivativeis wrong.
sorry :(
Remove the old related code, also RouteBuilder::getRouteCollectionDuringRebuild is no longer needed.
RouteBuilder::getRouteCollectionDuringRebuild() is no longer needed, let's drop it.
| Issue category | Task, because its just cleanup of code |
|---|---|
| Issue priority | Normal, because the scope of the change is small |
| Disruption | We remove an API method which was never recommended to be honest. IN common cases you have the $collectionavailable for your own, but in case you really need it, there is always a way to get the object using your own event subscriber. |
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | interdiff.txt | 802 bytes | dawehner |
| #4 | 2406439-4.patch | 6.26 KB | dawehner |
| #3 | interdiff.txt | 2.87 KB | dawehner |
| #3 | 2406439-3.patch | 5.92 KB | dawehner |
Comments
Comment #1
dawehnerThank you berdir for the pointer.
Comment #2
dawehner.
Comment #3
dawehner@berdir suggested to rename the file in that go
@dawehner removed a bunch of more code from the file.
Comment #4
dawehnerThis time less broken, maybe
Comment #6
dawehnerAdded a beta evaluation.
Comment #7
berdirThe EntityDerivate/EntityDeriver cleanup looks great to me, not 100% sure we can really remove the getCollectionDuringRebuild() stuff. I guess that means we officially no longer support that use case, which is probably OK.
Discussed with @dawehner and @alexpott in IRC, @alexpott suggested to mention this in the existing change record about the link template change: https://www.drupal.org/node/2382937. If someone searches for that method, then they can find it there.
Comment #8
alexpottCommitted 1c9e140 and pushed to 8.0.x. Thanks!
Can someone update https://www.drupal.org/node/2382937 to reflect this change.
Comment #10
dawehnerUpdated it.
Comment #11
berdirAnd made some small changes.