Problem/Motivation

Now that we have proper link template support EntityDerivativeis wrong.

sorry :(

Proposed resolution

Remove the old related code, also RouteBuilder::getRouteCollectionDuringRebuild is no longer needed.

Remaining tasks

User interface changes

API changes

RouteBuilder::getRouteCollectionDuringRebuild() is no longer needed, let's drop it.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because its just cleanup of code
Issue priority Normal, because the scope of the change is small
Disruption We remove an API method which was never recommended to be honest. IN common cases you have the $collectionavailable for your own, but in case you really need it, there is always a way to get the object using your own event subscriber.
CommentFileSizeAuthor
#4 interdiff.txt802 bytesdawehner
#4 2406439-4.patch6.26 KBdawehner
#3 interdiff.txt2.87 KBdawehner
#3 2406439-3.patch5.92 KBdawehner
#1 2406439-1.patch3.34 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
2406439-1.patch3.34 KB

Thank you berdir for the pointer.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Title: Cleanup EntityDerivative » Cleanup EntityDerivative and RouteBuilderInterface
Issue summary: View changes

.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
2406439-3.patch5.92 KB
interdiff.txt2.87 KB

@berdir suggested to rename the file in that go
@dawehner removed a bunch of more code from the file.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
2406439-4.patch6.26 KB
interdiff.txt802 bytes

This time less broken, maybe

The last submitted patch, 3: 2406439-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue summary: View changes

Added a beta evaluation.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

The EntityDerivate/EntityDeriver cleanup looks great to me, not 100% sure we can really remove the getCollectionDuringRebuild() stuff. I guess that means we officially no longer support that use case, which is probably OK.

Discussed with @dawehner and @alexpott in IRC, @alexpott suggested to mention this in the existing change record about the link template change: https://www.drupal.org/node/2382937. If someone searches for that method, then they can find it there.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs change record updates

Committed 1c9e140 and pushed to 8.0.x. Thanks!

Can someone update https://www.drupal.org/node/2382937 to reflect this change.

  • alexpott committed 1c9e140 on 8.0.x 
    Issue #2406439 by dawehner: Cleanup EntityDerivative and...
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Updated it.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

And made some small changes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.