Follow up to #2308187: Provide a twig extension for file_create_url, see comment #58 in that issue.

+++ b/core/modules/system/src/Tests/Theme/EngineTwigTest.php
@@ -83,4 +83,13 @@ public function testTwigLinkGenerator() {
+   * Tests the file url Twig functions.

Fix this comment line. Should be something like "Tests the file_url Twig function."

+++ b/core/modules/system/tests/modules/twig_theme_test/src/TwigThemeTestController.php
@@ -49,4 +49,13 @@ public function linkGeneratorRender() {
+   * Renders for testing file_create_url functions in a Twig template.

Fix this comment line. Should be something like "Renders for testing file_url functions in a Twig template."

The important point with both of these is the Twig function is called "file_url".

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it is just a comment change.
Issue priority Normal because just a comment change.
Unfrozen changes Unfrozen because it only changes comments.
Disruption No disruption.
CommentFileSizeAuthor
#2 revised-document-file-url-2405823-2.patch1.16 KBzealfire

Comments

zealfire’s picture

zealfire commented
Assigned: Unassigned » zealfire
zealfire’s picture

zealfire commented
Status: Active » Needs review
StatusFileSize
new revised-document-file-url-2405823-2.patch1.16 KB

Made the changes as required above.Please review.
Thanks.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

+1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 85f4178 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 85f4178 on 8.0.x 
    Issue #2405823 by zealfire: Comment fix in Twig tests for file_url

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.