Closed (fixed)
Project:
HTML Purifier
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Jan 2015 at 20:08 UTC
Updated:
9 Sep 2016 at 20:34 UTC
Jump to comment: Most recent
Comments
Comment #1
heddnComment #2
heddnCommerce 8.x is depending on https://www.drupal.org/project/composer_manager, rather than using libraries. The only thing is that css/js gets tricky. You have to just guess where it exits. See http://webmozarts.com/2014/12/03/puli-powerful-resource-management-for-php.
If it becomes too much of an issue, we might need to copy in the appropriate css into the D8 module to style the configuration form.
Comment #3
heddnCommerce does it this way:
https://github.com/commerceguys/commerce/blob/8.x-2.x/composer.json
Here is the blog post:
https://drupalcommerce.org/blog/31782/managing-d8-module-dependencies-ne...
Comment #4
heddnComment #5
heddnComment #6
heddnAdded first attempt at support into https://github.com/heddn/htmlpurifier
Comment #7
heddnNOTE: As of the commit in #6, the process to pull in the upstream library has changed from using libraries to composer_manager. The steps to pull in the library using composer are listed in this blog: https://drupalcommerce.org/blog/31782/managing-d8-module-dependencies-ne...
Comment #8
naveenvalechaCan we only add the composer.json in the module and remove the hard dependency of the Composer Manager same as drupal module upgrador do ?
Comment #9
naveenvalechaCorrection with #6 https://github.com/heddn/htmlpurifier/pull/6
Needs Work as per #7
Comment #10
naveenvalechaThe PR has been merged and code has been pushed on the d.o. as well. Marking this as fixed