Problem/Motivation

NodeRevisionAccessCheck is DB dependent for a really simple query.

Proposed resolution

Bump query into node storage.

Remaining tasks

None.

User interface changes

API changes

There's a new method on NodeStorage.

Beta phase evaluation

-

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug
Unfrozen changes Unfrozen because it's a bug.
Disruption Disruptive for contributed and custom modules : all existing node storages will need to add a new method. AFAIK there are ~1 complete node storages in contrib and even that's mine. In turn, however, NodeRevisionAccessCheck overrides can be removed.
CommentFileSizeAuthor
node_count.patch4.5 KBchx

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review

+1

It is a good idea to extract those custom sql queries for various reasons.

I'll RTBC when the testbot thinks its okay :)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Alright

Thank you for the patch!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e2e00e9 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed e2e00e9 on 8.0.x 
    Issue #2405163 by chx: NodeRevisionAccessCheck is database dependent

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.