Problem/Motivation

core/themes/bartik/css/components/search.css contains duplicate css of core/themes/bartik/css/components/search-results.css.

Proposed resolution

Remove the duplicate css from core/themes/bartik/css/components/search.css since the belongs to the search result component.

Remaining tasks

  1. Write a patch
  2. Review
  3. Attach screenshots to prove nothing broke

User interface changes

None

API changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it does not solve any bugs or introduce any new features.
Issue priority Normal because it doesn't affect any major systems
Unfrozen changes Unfrozen because it only changes css.
Prioritized changes The main goal of this issue is removing duplicate code.
Disruption Not disruptive
CommentFileSizeAuthor
#5 2404963-4-after.png119.14 KBidebr
#5 2404963-4-before.png117.86 KBidebr
#4 remove-bartik-duplicate-css-2404963-4.patch733 bytesherom
remove-bartik-duplicate-css.patch1.47 KBherom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Issue tags: +Needs reroll
Related issues: +#1342054: [META] Clean up templates and CSS

List.css no longer exists in Bartik as part of the #1342054: [META] Clean up templates and CSS work.

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Issue summary: View changes
emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Status: Needs review » Needs work
herom’s picture

herom CreditAttribution: herom commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
remove-bartik-duplicate-css-2404963-4.patch733 bytes
idebr’s picture

idebr CreditAttribution: idebr commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
2404963-4-before.png117.86 KB
2404963-4-after.png119.14 KB

Thanks @herom, I can confirm the duplicate css can be removed safely.

Screenshots before/after:

idebr’s picture

idebr CreditAttribution: idebr commented
Title: Remove duplicate CSS in Bartik theme » Remove duplicate search results CSS in Bartik theme
Issue summary: View changes
Issue tags: +frontend

I have updated the issue summary to reflect the contents of the patch and included a beta evaluation.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Nice cleanup. Committed bab56d8 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed bab56d8 on 8.0.x 
    Issue #2404963 by herom, idebr: Remove duplicate search results CSS in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.