Problem/Motivation

Proposed resolution

Remove the function.

Remaining tasks

User interface changes

API changes

Remove language_set_browser_drupal_langcode_mappings()

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue priority Critical because it blocks #2392319: Config objects (but not config entities) should by default be immutable
Disruption None
Files: 
CommentFileSizeAuthor
language.remove_useless_setter_wrapper.patch2.4 KBeffulgentsia
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,562 pass(es). View

Comments

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Quickfix +Quickfixm D8MI, +sprint, +language-base

Makes sense. I don't believe we'll need the wrapper.

alexpott’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

These wrappers are legacy code in the language module there is no need to maintain them imo. This method has only ever existed in D8 - it was introduced by one of the patches committed on #365615: Language detection not working correctly for most Chinese readers (and add a user interface for all browser language mappings) (wow what a mess of an issue). And I don't believe removing this warrants a CR.

Committed 8e52db7 and pushed to 8.0.x. Thanks!

Gábor Hojtsy’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.