Problem/Motivation

The test class Drupal\field\Tests\Views\ApiDataTest was not moved to the views module as part of #2399931: Generic entity api field handler should live in views module not in field module.

Proposed resolution

Move it there.

Remaining tasks

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because some code was overlooked in a previous cleanup task
Unfrozen changes Unfrozen because it only changes the location of a Simpletest to live in the proper module
CommentFileSizeAuthor
#5 move-views-data-test-2404265-04.patch892 bytesjhedstrom
#5 interdiff.txt744 bytesjhedstrom
#2 move-views-data-test-2404265-02.patch770 bytesjhedstrom

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue tags: +VDC, +Quickfix
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new move-views-data-test-2404265-02.patch770 bytes

As I moved the test, I realized it extends from FieldTestBase, perhaps this is the time to move a lot of those needed methods to traits?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ b/core/modules/views/src/Tests/ApiDataTest.php
@@ -2,15 +2,17 @@
+ * Contains \Drupal\views\Tests\ApiDataTest.

We need to name it FieldApiDataTest or something more specifiy than ApiDataTest, ... previously field ensured that specificity.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review

Here's a more descriptive name. I'd be happy to convert FieldTestBase to a trait if this is the appropriate place to do so.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
StatusFileSize
new interdiff.txt744 bytes
new move-views-data-test-2404265-04.patch892 bytes

This time with a patch!

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you, i'm fine with the name.

@jhedstrom Please add a quick beta evaluation.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update

This issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
Status: Needs work » Reviewed & tested by the community

I added a beta phase evaluation to the issue summary.

Back to RTBC per #6.

  • alexpott committed f52ece0 on 8.0.x 
    Issue #2404265 by jhedstrom: Follow-up: ApiTestData should be in the...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs issue summary update

Committed f52ece0 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.