Drupal\Core\Menu\StaticMenuLinkOverrides uses a config file called menu_link.static.overrides. This is wrong because it is a core service and should be prefixed by core. and also if there was a module called menu_link uninstalling that module would remove this configuration.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because of the uninstall problem
Issue priority Major because the unisntall problem would be hard to track
Disruption Potentially disruptive if existing sites used this functionality - however all they would have to do is rename the config - so I think the disruption is very small.
CommentFileSizeAuthor
#9 2403169.9.patch3.7 KBalexpott
#9 4-9-interdiff.txt283 bytesalexpott
#5 2403169.4.patch3.42 KBalexpott
#5 2-4-interdiff.txt3.38 KBalexpott
#2 2403169.2.patch3.39 KBalexpott
#2 1-2-interdiff.txt3.38 KBalexpott
#1 2403169.1.patch3.27 KBalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2403169.1.patch3.27 KB

Renamed to core.menu_link.overrides - the static seems superfluous.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 1-2-interdiff.txt3.38 KB
new 2403169.2.patch3.39 KB

@dawhner said in IRC that the static part is important so...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I've gone for core.static_menu_link_overrides since it makes the class name in snake case.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2-4-interdiff.txt3.38 KB
new 2403169.4.patch3.42 KB

From @dawehner in IRC - Let's add a namespace in there so core. does not get crowded. Gone for core.menu.static_menu_link_overrides

The last submitted patch, 2: 2403169.2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

<3 as this matches exactly the php namespace.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2403169.4.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 4-9-interdiff.txt283 bytes
new 2403169.9.patch3.7 KB

lolz

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 76cf704 on 8.0.x 
    Issue #2403169 by alexpott: Static menu link override configuration is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.