Drupal\Core\Menu\StaticMenuLinkOverrides uses a config file called menu_link.static.overrides. This is wrong because it is a core service and should be prefixed by core. and also if there was a module called menu_link uninstalling that module would remove this configuration.
| Issue category | Bug because of the uninstall problem |
|---|---|
| Issue priority | Major because the unisntall problem would be hard to track |
| Disruption | Potentially disruptive if existing sites used this functionality - however all they would have to do is rename the config - so I think the disruption is very small. |
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2403169.9.patch | 3.7 KB | alexpott |
| #9 | 4-9-interdiff.txt | 283 bytes | alexpott |
| #5 | 2403169.4.patch | 3.42 KB | alexpott |
| #5 | 2-4-interdiff.txt | 3.38 KB | alexpott |
| #2 | 2403169.2.patch | 3.39 KB | alexpott |
Comments
Comment #1
alexpottRenamed to
core.menu_link.overrides- the static seems superfluous.Comment #2
alexpott@dawhner said in IRC that the static part is important so...
Comment #3
alexpottI've gone for
core.static_menu_link_overridessince it makes the class name in snake case.Comment #5
alexpottFrom @dawehner in IRC - Let's add a namespace in there so core. does not get crowded. Gone for
core.menu.static_menu_link_overridesComment #7
dawehner<3 as this matches exactly the php namespace.
Comment #9
alexpottlolz
Comment #10
catchCommitted/pushed to 8.0.x, thanks!