This form was recently converted to save #2355909: language.settings config is not scalable the settings into configuration entities. ContentLanguageSettingsForm use ConfigFormBase but does not save configuration.

Blocks #2392319: Config objects (but not config entities) should by default be immutable

Files: 
CommentFileSizeAuthor
#3 2403101.3.patch2.2 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,432 pass(es). View
#3 1-3-interdiff.txt2.2 KBalexpott
d8.content-language-settings-form.patch1.25 KBalexpott
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details.. View

Comments

alexpott’s picture

Issue tags: +Quick fix

Status: Needs review » Needs work

The last submitted patch, d8.content-language-settings-form.patch, failed testing.

alexpott’s picture

Status: Needs work » Needs review
FileSize
2.2 KB
2.2 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,432 pass(es). View

Fixed constructor by removing call to parent and unnecessary injection of the config factory.

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, fixes what the scope was set out to do. While not critical in its own right, blocks the critical at #2392319: Config objects (but not config entities) should by default be immutable.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 9e91941 on 8.0.x
    Issue #2403101 by alexpott: ContentLanguageSettingsForm is not a config...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.