Follow-up to #2331685: PHPUnit deprecated assertTag(), assertNotTag() and assertSelectEquals()

Problem/Motivation

@dawehner in #2331685-15: PHPUnit deprecated assertTag(), assertNotTag() and assertSelectEquals()

Ideally not all our unit tests would extend from dom test, but well, maybe we have to wait until the trait is in.

Remaining tasks

Create a similar patch to https://github.com/phpunit/phpunit-dom-assertions/pull/4 for drupal

User interface changes

None

API changes

UnitTestCase will again extend \PHPUnit_Framework_TestCase
And all the phpunit test using assertTag() and assertSelectEquals() will use this trait

Comments

dawehner’s picture

dawehner
Primary language German
commented
Title: Add phpunit-dom-assertions trait to allow simple extensibility of existing test classes » Use phpunit-dom-assertions trait to allow simple extensibility of existing test classes

Well yeah I would wait until the phpunit merge is in and then just use it.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

PR merged. Now postpone on #2331685: PHPUnit deprecated assertTag(), assertNotTag() and assertSelectEquals()

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Postponed » Closed (won't fix)

We are not using phpunit-dom-assertions anymore so won't fix.