Closed (fixed)
Project:
jReject
Version:
7.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Feature request
Assigned:
Reporter:
Created:
6 Jan 2015 at 19:26 UTC
Updated:
5 Jan 2016 at 17:54 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
solenity commentedComment #2
solenity commentedComment #3
solenity commentedComment #4
WorldFallz commentedpatch still applies and addresses a major issue with the module: allowing more recent browser versions. Please consider adding asap.
Also, if you need co-maintainers-- I'd be happy to help out. There's a lot patches in the issue queue which could be applied.
Thanks.
Comment #5
ndobromirov commentedHi all,
1. The patch works perfectly on new installs.
Moving to critical, as the module is hardly usable from dev's point of view, as old browsers are also hard to install and we need to be able to test on the new ones also.
2. It will need also an update hook to update existing site configurations to the new format.
As it is currently, the configs will be lost on first save of the admin form and users will see notices on it.
This is not major, as with valid re-save and filling the data in the form, it will still work, not automatically though.
3. Might be for follow-up issue, but please follow the Drupal coding standards in the literal arrays in the install, as it very ugly as it is now.
BR,
Nikolay Dobromirov.
Comment #6
sinn commentedI've changed approach of browser settings. In my proposal you can just set highest number of browser that have to be rejected.
Comment #8
eugene.ilyin commented@sinn, hi! I have committed your patch but with some corrections. Please check it and let me know if you not agree with something.
If all is fine please close this issue.
Comment #9
eugene.ilyin commentedI'm also would be glad if somebody will test the last dev version of module and this correction.
Comment #10
sinn commented#7 works good for me
Comment #11
eugene.ilyin commentedOkay, I'm closing issue.