Here is a patch that allows setting the max browser version available in the jReject config pages. This allows setting a max version number as an integer for each browser. Browser versions up to the max version will appear as options that can be selected (see screenshot).

jReject setting max browser version

Comments

solenity’s picture

solenity’s picture

Status: Active » Needs review
StatusFileSize
new4.02 KB
solenity’s picture

StatusFileSize
new4.09 KB
WorldFallz’s picture

Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

patch still applies and addresses a major issue with the module: allowing more recent browser versions. Please consider adding asap.

Also, if you need co-maintainers-- I'd be happy to help out. There's a lot patches in the issue queue which could be applied.

Thanks.

ndobromirov’s picture

Priority: Major » Critical
Status: Reviewed & tested by the community » Needs work

Hi all,

1. The patch works perfectly on new installs.
Moving to critical, as the module is hardly usable from dev's point of view, as old browsers are also hard to install and we need to be able to test on the new ones also.

2. It will need also an update hook to update existing site configurations to the new format.
As it is currently, the configs will be lost on first save of the admin form and users will see notices on it.
This is not major, as with valid re-save and filling the data in the form, it will still work, not automatically though.

3. Might be for follow-up issue, but please follow the Drupal coding standards in the literal arrays in the install, as it very ugly as it is now.

BR,
Nikolay Dobromirov.

sinn’s picture

Status: Needs work » Needs review
StatusFileSize
new310.37 KB
new11.93 KB

I've changed approach of browser settings. In my proposal you can just set highest number of browser that have to be rejected.

  • eugene.ilyin committed 26d4ff8 on authored by sinn
    Issue #2402783 by solenity, sinn: Add max browser version setting
    
  • eugene.ilyin committed c492cd6 on
    Issue #2402783 by eugene.ilyin: Add max browser version setting
    
eugene.ilyin’s picture

@sinn, hi! I have committed your patch but with some corrections. Please check it and let me know if you not agree with something.
If all is fine please close this issue.

eugene.ilyin’s picture

I'm also would be glad if somebody will test the last dev version of module and this correction.

sinn’s picture

Status: Needs review » Reviewed & tested by the community

#7 works good for me

eugene.ilyin’s picture

Status: Reviewed & tested by the community » Fixed

Okay, I'm closing issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.