Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
ExtensionDiscovery::scan() is huge, which makes it very hard to override, and hard to maintain.
We can significantly reduce its size by moving out the extension filtering and sorting to helper methods.
Beta evaluation: This is a minimum-disruption internal refactoring with the goal to reduce ExtensionDiscovery fragility, and make it easier for ExtensionDiscovery to be extended and modified (which is something that the composer_manager module needs, for example).
Comment | File | Size | Author |
---|---|---|---|
#4 | interdiff.txt | 2.25 KB | bojanz |
#4 | 2401607-4-refactor-extensiondiscovery-scan.patch | 6.38 KB | bojanz |
#3 | interdiff.txt | 1.81 KB | bojanz |
#3 | 2401607-3-refactor-extensiondiscovery-scan.patch | 6.36 KB | bojanz |
#1 | 2401607-1-refactor-extensiondiscovery-scan.patch | 6.25 KB | bojanz |
Comments
Comment #1
bojanz CreditAttribution: bojanz commentedInitial patch.
Comment #2
dawehnerGiven its documentation we could find a better name:
filterByCurrentInstallationProfile
or something along this lines.Comment #3
bojanz CreditAttribution: bojanz commentedLet's go with this then.
Comment #4
bojanz CreditAttribution: bojanz commentedDisregard #3, missed a spot.
Interdiff is against #1.
Comment #6
dawehnerThank you naming things in a sane way.
Comment #7
bojanz CreditAttribution: bojanz commentedComment #8
alexpottThanks for adding the beta evaluation to the IS - it's definitely good for us to make composer manager's life easier.
Committed 1b738ca and pushed to 8.0.x. Thanks!