Problem/Motivation

The Views field 'Link to edit' creates the following link: /user/1/edit?destination%5Bdestination%5D=/admin/people

This should be /user/1/edit?destination=/admin/people

Proposed resolution

Fix the destination parameter in 'Link to edit user' to include only one destination parameter.

Remaining tasks

  • Write a patch
  • Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#15 2401265-15-do-not-test.patch5.45 KBidebr
#10 2401265-10.patch3.4 KBidebr
#10 interdiff-10-7.txt1.03 KBidebr
#10 2401265-10.fail_.patch2.68 KBidebr
#7 2401265-7.patch3.29 KBidebr
#7 2401265-7.fail_.patch2.58 KBidebr
#7 interdiff-7-3.txt2.58 KBidebr
#3 2401265-3.patch732 bytesidebr
link-to-edit-user-before.png211.3 KBidebr

Comments

dawehner’s picture

dawehner
Primary language German
commented

This is currently broken due to #2404603: Add proper support for Url objects in FieldPluginBase::renderAsLink(), so we can remove EntityInterface::getSystemPath() but I think this issue os worth to keep to for example add dedicated test coverage.

idebr’s picture

idebr commented
Title: Views field 'Link to edit user' is no link » Views field 'Link to edit user' has a duplicate destination parameter, returns WSOD

#2404603: Add proper support for Url objects in FieldPluginBase::renderAsLink(), so we can remove EntityInterface::getSystemPath() has been committed and the 'Link to edit user' now renders a link. However, the destination parameter has another destination parameter. This kills the website.

idebr’s picture

idebr commented
Title: Views field 'Link to edit user' has a duplicate destination parameter, returns WSOD » Views field 'Link to edit user' has a destination parameter, returns WSOD
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2401265-3.patch732 bytes

Attached patch removes the destination parameter from the destination parameter. I updated the issue summary to reflect the new issue.

idebr’s picture

idebr commented
Title: Views field 'Link to edit user' has a destination parameter, returns WSOD » Views field 'Link to edit user' has a duplicate destination parameter, returns WSOD
dawehner’s picture

dawehner
Primary language German
commented

Would you mind trying writing a test?

idebr’s picture

idebr commented
Assigned: Unassigned » idebr
Status: Needs review » Needs work

Sure, I'll write a test :)

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-7-3.txt2.58 KB
new 2401265-7.fail_.patch2.58 KB
new 2401265-7.patch3.29 KB

Tests added. I wonder what is the best way to test the destination parameter on the 'Edit' link in a test? Right now its hardcoded to the current path.

The last submitted patch, 7: 2401265-7.fail_.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: 2401265-7.patch, failed testing.

idebr’s picture

idebr commented
Assigned: idebr » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2401265-10.fail_.patch2.68 KB
new interdiff-10-7.txt1.03 KB
new 2401265-10.patch3.4 KB

Alright, this should fix the failing test to fail only on the Edit link failure.

The last submitted patch, 10: 2401265-10.fail_.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented

This doesn't block this bug to get in. Can we please add a quick beta evaluation?

+++ b/core/modules/user/src/Tests/Views/UserLinkEditTest.php
@@ -0,0 +1,40 @@
+ */
+class UserLinkEditTest extends UserTestBase {
+

In case you want to you could try to write a kernel test instead, as it would make it way nicer to run the test, due to its better performance.

idebr’s picture

idebr commented

Oh, that sounds good. I haven't written one before but i'll have a look tomorrow.

dawehner’s picture

dawehner
Primary language German
commented

FieldCounterTest might give you an idea how to do it.

idebr’s picture

idebr commented
Status: Needs review » Needs work
StatusFileSize
new 2401265-15-do-not-test.patch5.45 KB

I tried extending UserUnitTestBase but I couldn't get the user edit link to render in the test. Other fields such as the user name were rendering fine. Do I need to override any access checks for the edit link to show up?

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Closed (works as designed)

This handler was removed in #2322949: Implement generic entity link view field handlers and now the \Drupal\views\Plugin\views\field\EntityOperations is used.