Now that the node frontpage listing and taxonomy pages are views the node.settings::items_per_page configuration is no longer used and should be removed. This value is set using a form alter. Form alters that save config are being converted in #2392319: Config objects (but not config entities) should by default be immutable to objects. This removal should happen first.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue priority Critical because it blocks #2392319: Config objects (but not config entities) should by default be immutable
Disruption Not disruptive since it is not used in core. If contrib is using the old variable / new config it will need to be updated.
Files: 
CommentFileSizeAuthor
#1 2401035.1.patch4.48 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,364 pass(es). View

Comments

alexpott’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
4.48 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,364 pass(es). View

Patch to remove this.

jibran’s picture

Status: Needs review » Reviewed & tested by the community

Fair enough.

swentel’s picture

Status: Reviewed & tested by the community » Needs review

There's still code in migrate that refers to this, should this be removed ?

core/modules/migrate_drupal/src/Tests/Dump/Drupal6NodeSettings.php:      'name' => 'default_nodes_main',
core/modules/migrate_drupal/config/install/migrate.migration.d6_node_settings.yml:    - default_nodes_main
core/modules/migrate_drupal/config/install/migrate.migration.d6_node_settings.yml:  items_per_page: default_nodes_main
alexpott’s picture

@swentel yep - doesn't the patch in #1 do that?

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Applied the patch and went through the leftover instance of 'items_per_page' and they all have been related to either block settings or views, so we are fine here.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 451bf65 on 8.0.x
    Issue #2401035 by alexpott: items_per_page in node.settings is no longer...
swentel’s picture

Ugh right, sorry, grepped after I had reset my environment - was closing a lot duplicate issues regarding this setting in the queue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.