Bulk form actions display action message in the confirmation form

Do we need some kind of test coverage here?

.

Added test, I also had to reroll the original patch.

Action message in the confirmation page/form is no longer shown after the patch is applied.

before patch

select content to be deleted

action message IS visible in confirmation page

delete confirmed

after patch

select content to be deleted

no action message visible in confirmation page

delete confirmed

+++ b/core/modules/action/src/Tests/BulkFormTest.php
@@ -148,6 +148,9 @@ public function testBulkForm() {
+    // Make sure we don't show an action message while we are still
+    // on the confirmation page.
+    $this->assertNoText(t('Delete content was applied to 5 items.'));
     $this->drupalPostForm(NULL, array(), t('Delete'));

Can we add a positive assertion of the text after the post. An assertNoText with a corresponding assertion can easily have false positives if the underlying code changes.

Fixed nitpicks.

Nice work! Thanks for the beta evaluation, the screenshots, and the test-only patch.

1. +++ b/core/modules/action/src/Tests/BulkFormTest.php
   @@ -148,7 +148,11 @@ public function testBulkForm() {
   +    // Make sure we don't show an action message while we are still on the
   +    // confirmation page.
   +    $this->assertNoText(t('Delete content was applied to 5 items.'));
   

   Following up on @alexpott's feedback in #10. Instead of or in addition to the assertNoText(), could we maybe check drupal_get_messages() or something along those lines? Just to confirm that there are no messages, regardless of what exactly we may make the message text in the future.

2. +++ b/core/modules/system/src/Plugin/views/field/BulkForm.php
   @@ -291,13 +291,16 @@ public function viewsFormSubmit(&$form, FormStateInterface $form_state) {
   +      else {
   +        // Don't display the message unless there are some elements affected and
   +        // there is no confirmation form.
   +        $count = count(array_filter($form_state->getValue($this->options['id'])));
   +        if ($count) {
   +          drupal_set_message($this->formatPlural($count, '%action was applied to @count item.', '%action was applied to @count items.', array(
   +            '%action' => $action->label(),
   +          )));
   +        }
   

   Also, I don't think there is test coverage for this code path. Can we add that as well?

1. I decided to just check if a container with class "messages--status" exists, since drupal_get_messages() will always be empty after messages are displayed.
2. This actually has test coverage in the same method already.
   

   $this->assertText('Make content sticky was applied to 10 items.');
   $this->assertText('Unpublish content was applied to 1 item.');
   

Thanks, that works nicely.

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed and pushed to 8.0.x.