Follow up from #2396981: Use Drupal coding standards which only covered audit and core bridge modules.

CommentFileSizeAuthor
#1 2399797-services-standards-1.patch44.79 KBkim.pepper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented
Status: Active » Needs review
FileSize
2399797-services-standards-1.patch44.79 KB

This fixes coding standards in all services includes (mostly adding docs).

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented 
+++ b/services/s3.inc
@@ -937,19 +1094,23 @@ class StorageS3 extends StorageContainer implements StorageContainerInterface {
-      if (https && strpos($this->settings['bucket'], '.') !== false) {
+      if ($https && strpos($this->settings['bucket'], '.') !== FALSE) {

This looks like a bug.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented
Parent issue: » #2396981: Use Drupal coding standards
Perignon’s picture

Perignon CreditAttribution: Perignon commented

Hrm... and I think that was done to fix a problem with buckets using HTTPS. Let me look at the Git history for that file before I fix this.

Perignon’s picture

Perignon CreditAttribution: Perignon commented
Assigned: Unassigned » Perignon
Perignon’s picture

Perignon CreditAttribution: Perignon commented

#2 - Yup a typo!

  • Perignon committed ff3d5dc on 7.x-1.x authored by kim.pepper 
    Issue #2399797 by kim.pepper: Use Drupal coding standards for services
Perignon’s picture

Perignon CreditAttribution: Perignon commented
Status: Needs review » Fixed
Perignon’s picture

Perignon CreditAttribution: Perignon commented

Thanks for the patches!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Perignon’s picture

Perignon CreditAttribution: Perignon commented
Issue tags: +Storage API 7.x-1.7