After creating a view and setting 'Use Ajax' to 'Yes', links are not loaded via Ajax. - They still cause a page refresh.

It looks like this is due to an array nesting issue when preparing drupalSettings in views.module, introduced by #2382557: Change JS settings into a separate asset type.

Beta phase evaluation

tr>

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because views ajax is broken
Issue priority Critical because it affects a lot of users.
Disruption Not disruptive, because it doesn't change an API, it just fixes the bug.
CommentFileSizeAuthor
#6 23399195-views_ajax-6.patch3.05 KBmondrake
#6 interdiff_3-6.txt2.03 KBmondrake
#3 23399195-views_ajax-3.patch1.83 KBmondrake
#3 23399195-views_ajax-3-test-only.patch1.15 KBmondrake
#1 views_ajax-1.patch703 bytesmondrake

Comments

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new views_ajax-1.patch703 bytes

Patch.

dawehner’s picture

dawehner
Primary language German
commented

Oh wow.

Thank you for the patch, do you mind writing some kind of test for it?
You could expand \Drupal\views\Tests\ViewAjaxTest
to check whether the required drupalSetting is available after the drupalGet() call?

mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new 23399195-views_ajax-3-test-only.patch1.15 KB
new 23399195-views_ajax-3.patch1.83 KB

Ok, here with some tests over the returning drupalSettings as per #2.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/core/modules/views/views.module
@@ -55,7 +55,7 @@ function views_help($route_name, RouteMatchInterface $route_match) {
-    $view->element['#attached']['drupalSettings']['views'] = array(
+    $view->element['#attached']['drupalSettings'] = array(
       'views' => array(
         'ajax_path' => \Drupal::url('views.ajax'),
         'ajaxViews' => array(

Wondering if the fix should be the other way round, even if the patch is going to be a bit more complicated.

This replaces the whole drupalSettings array and prevents anyone from adding something there. I guess that is not likely to happen but we had real bugs related to code like this in the past.

The last submitted patch, 3: 23399195-views_ajax-3-test-only.patch, failed testing.

mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new interdiff_3-6.txt2.03 KB
new 23399195-views_ajax-6.patch3.05 KB

Changes as per #4.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks great for me now!

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes

  • catch committed 118abbc on 8.0.x 
    Issue #2399195 by mondrake: Views setting 'Use Ajax' doesn't work
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.