Problem/Motivation

There's a sort($parameters->conditions); in MenuTreeStorage::loadTreeData. But these conditions are an associated array with the db column being the key. This gets lost.

Proposed resolution

Use asort

Remaining tasks

Write a test.

User interface changes

None.

API changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because disabled links don't get filtered
Prioritized changes This is a bugfix.
CommentFileSizeAuthor
#6 2398805-6.patch2.59 KBdawehner
#6 interdiff.txt1.84 KBdawehner
#1 2398805-1.patch1.62 KBdawehner
#1 2398805-1-fail.patch940 bytesdawehner
asort.patch717 byteschx

Comments

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2398805-1-fail.patch940 bytes
new 2398805-1.patch1.62 KB

Here is a test for that. Good spot of this bug!

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

I do not think it's RTBC'ing my code when all I wrote is 1 character (literally).

The last submitted patch, 1: 2398805-1-fail.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented

Ha, true.

chx’s picture

chx commented
Issue summary: View changes
Issue tags: -Needs tests
dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new interdiff.txt1.84 KB
new 2398805-6.patch2.59 KB

A voice convinced me to also test ::onlyEnabledLinks() :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2398805-6.patch, failed testing.

Status: Needs work » Needs review

dawehner queued 6: 2398805-6.patch for re-testing.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Bot fail.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 8096a6c and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation.

  • alexpott committed 8096a6c on 8.0.x 
    Issue #2398805 by dawehner, chx: MenuTreeStorage::loadTreeData loses...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Great fix; thanks; I think I might've been responsible for this bug :(

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.