Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Bartik's code needs to meet current Drupal coding standards.
Proposed resolution
This issue takes a specific section of Bartik's code, it acts as a "component" issue and improves that section of code with minimal impact on the rest of Bartik's codebase.
This issue aims to clean up and properly format the CSS and templates files without breaking Bartik visually.
This issue primarily looks at the css/components/book.css file.
Work that needs to be included in patches for this issue are fully outlined in the META issue #1342054: [META] Clean up templates and CSS.
Remaining tasks
- Assess the code applicable to this patch and figure out what work outlined in #1342054: [META] Clean up templates and CSS needs to be included in the patch.
- Write a patch with as much work as you want to include, upload and comment what you have done.
- Review the patch - code review and visual changes
- Upload screenshots to show nothing/something is broken on the frontend
- If something is broken a new patch is needed to fix the visual regressions
User interface changes
None, we are cleaning up CSS and markup in templates. The use of Bartik's UI and design will stay the same.
API changes
n/a
Beta phase evaluation
| Issue category | Task because it is a code clean up overhaul of a theme. |
|---|---|
| Unfrozen changes | Unfrozen because it only refactors CSS and templates, no changes to UI or APIs |
| Prioritized changes | The main goal of this issue is usability and performance. We want Bartik code to be up to date and something to be proud of. |
| Disruption | No disruption it's only refactoring code not changing how to use the theme |
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | css_cleanup-2398455-6.patch | 379 bytes | SteffenR |
Comments
Comment #1
emma.mariaComment #2
emma.mariaComment #3
emma.mariaComment #4
emma.mariaMarking this as a Novice for a new contributor to work on.
This issue only needs one change added to the file as far as I can see which is a file comment.
Looking forward to reviewing the patch :)
Comment #5
SteffenRComment #6
SteffenR@emma.maria - as already mentioned by you, i added the file-comment to the book.css file. The rest of the CSS looks fine for me and does not need any further cleanup.
SteffenR
Comment #7
SteffenRComment #8
emma.mariaThe patch applies cleanly with no errors. The file comment added in the patch meets the Drupal CSS formatting guidelines and describes the contents of the file well.
No screenshots are needed as the patch is only a file comment. Marking this RTBC. Thanks @SteffenR!
Comment #9
alexpottCommitted 2045691 and pushed to 8.0.x. Thanks!
Comment #11
LewisNymanI created a follow up to sort out the selectors here: #2405445: Refactor book module CSS files inline with our CSS standards