This is a followup to #2388905: menu link storage override requires too much copy-paste and deals with the same problem: while the menu tree storage is pluggable a lot of logic is inside MenuTreeStorage. If one wants to override this class huge chunks need to be copy pasted. This issue deals with preSave().
Break out the parent setting logic out to a separate method. This opens the door to things like #2398983: Switch from base 36 to base 128 and use it for menu tree in contrib if core doesn't want it / schedules don't match etc.
None.
None.
None.
| Prioritized changes | This is a trivial bugfix. |
|---|---|
| Disruption | Absolutely none. |
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2396761_4.patch | 4.14 KB | chx |
| #4 | interdiff.txt | 1.31 KB | chx |
Comments
Comment #2
chx commentedEh, PHP and typehinting.
Comment #4
chx commentedSome minor cleanup needed.
Comment #5
dawehner+1 from me.
Comment #10
chx commentedSigh. Bot fails.
Comment #11
alexpottThis issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary. I can see that this is zero disruption but are there other benefits in doing this?
Comment #12
chx commentedComment #13
alexpottCommitted 1777332 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.